Skip to content

Conversation

@JonathanLeeWH
Copy link
Contributor

@JonathanLeeWH JonathanLeeWH commented Jul 3, 2021

  • Amended nodejs.yml GitHub workflow with newly added setup-node build in cache support. (Link)
  • Added additional GitHub Actions workflow which connects to a docker mongodb instance
  • Added node.js-with-docker-db.yml GitHub Actions
  • Added docker-compose-test-ci-db-only.yml docker compose
  • Added testing of node version 14 and 16 and also check for latest node version in node.js-with-docker-db.yml
  • Amended node.js.yml with check-latest: true to check latest nodejs version

@JonathanLeeWH JonathanLeeWH added enhancement New feature or request github_actions Pull requests that update Github_actions code priority.high High priority labels Jul 3, 2021
@JonathanLeeWH JonathanLeeWH added this to the Version 1.0.0 milestone Jul 3, 2021
@JonathanLeeWH JonathanLeeWH self-assigned this Jul 3, 2021
JonathanLeeWH and others added 2 commits July 3, 2021 12:17
…ongodb instance

Added `node.js-with-docker-db.yml` GitHub Actions

Added `docker-compose-test-ci-db-only.yml` docker compose
…th-docker-db-github-workflow

Added additional GitHub Actions workflow which connects to a docker `mongodb` instance
@JonathanLeeWH JonathanLeeWH added docker Related to docker Testing Related to testing labels Jul 3, 2021
JonathanLeeWH and others added 9 commits July 3, 2021 12:21
…-nodejs-with-docker-db-github-workflow

Resolved bug where there was a missing `run` parameter in `npm run test-ci` in `node.js-with-docker-db.yml`
…-nodejs-with-docker-db-github-workflow

Resolved bug in `node.js-with-docker-db.yml` `TEST_MONGODB_URI` environmental variable
…-nodejs-with-docker-db-github-workflow

Resolved bug in `node.js-with-docker-db.yml`
Added testing of `node version` `14` and `16 ` and also check for latest node version in node.js-with-docker-db.yml
Amended `Readme.md` with updated nodejs ci status badge
@JonathanLeeWH JonathanLeeWH added status.done Done and ready for review and merge documentation Improvements or additions to documentation labels Jul 3, 2021
@JonathanLeeWH JonathanLeeWH merged commit 656c61b into master Jul 3, 2021
@JonathanLeeWH JonathanLeeWH deleted the amended-github-workflow branch July 3, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Related to docker documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update Github_actions code priority.high High priority status.done Done and ready for review and merge Testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants