Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved software model with shortDescription, pricing, videoLink and twitterUsername fields #212

Merged

Conversation

JonathanLeeWH
Copy link
Contributor

  • Improved software model with shortDescription, pricing, videoLink and twitterUsername fields

Note: videoLink field validates if the video link is either youtube.com or vimeo.com as the plan is to initially support only youtube and vimeo as video hosting websites

  • Amended softwareTestUtils.js to match the updated software model
  • Amended post_software.rest test API endpoint file to match the updated software model

To be considered: To consider whether license field should be added in software model and whether it should accept a String (license type) or url type (the url to license)

…ink` and `twitterUsername` fields

Note: `videoLink` field validates if the video link is either `youtube.com` or `vimeo.com` as the plan is to initially support only youtube and vimeo as video hosting websites

Amended `softwareTestUtils.js` to match the updated `software` model

Amended `post_software.rest` test API endpoint file to match the updated `software` model
@JonathanLeeWH JonathanLeeWH added enhancement New feature or request status.done Done and ready for review and merge priority.high High priority db.model Related to database models/schemas Testing Related to testing labels Jul 31, 2021
@JonathanLeeWH JonathanLeeWH added this to the Version 1.0.0 milestone Jul 31, 2021
@JonathanLeeWH JonathanLeeWH self-assigned this Jul 31, 2021
@JonathanLeeWH JonathanLeeWH merged commit e0eba38 into integrate-with-frontend-web-app Jul 31, 2021
@JonathanLeeWH JonathanLeeWH deleted the improve-software-model branch July 31, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db.model Related to database models/schemas enhancement New feature or request priority.high High priority status.done Done and ready for review and merge Testing Related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant