Improved handling Google Service Account Approach in GitHub Actions #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f service account json file
Amended `dockerfile`, `dockerfile-ci,` `docker-compose.yml` with the new firebase admin service account environment variables Removed the encrypted secret `firebase.gpg`, the job for decryption of encrypted secrets, the `decrypt_firebase_secret.sh` shell script Removed `GOOGLE_APPLICATION_CREDENTIALS` environment variable which is no longer used
JonathanLeeWH
added
github_actions
JonathanLeeWH
changed the title
JonathanLeeWH
added
priority.high
Refactored `TEST_FIREBASE_CLIENT_API_KEY ` environment variables to `FIREBASE_CLIENT_API_KEY` as it is currently used not just for testing purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebaseConfig.jsto use environmental variables instead of service accountjsonfiledockerfile,dockerfile-ci,docker-compose.ymlwith the new firebase admin service account environment variablesfirebase.gpg, the job for decryption of encrypted secrets, thedecrypt_firebase_secret.shshell scriptGOOGLE_APPLICATION_CREDENTIALSenvironment variable which is no longer usedReadme.mddocumentation with the new firebase service account environment variablesTEST_FIREBASE_CLIENT_API_KEYenvironment variables toFIREBASE_CLIENT_API_KEYas it is currently used not just for testing purposesResolved #81