Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloudfare analytics script #166

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

azgcloudev
Copy link
Contributor

@rishabkumar7 it seems this should be the correct format

BTW, should we have the token in a vault instead of the actual repo?

@rishabkumar7
Copy link
Collaborator

@azgcloudev yeah let's use it as an env variable

@azgcloudev
Copy link
Contributor Author

@rishabkumar7 change done
variable: CLOUDFARE_ANALYTICS_TOKEN

Copy link
Collaborator

@rishabkumar7 rishabkumar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rishabkumar7 rishabkumar7 merged commit 8c5057a into learntocloud:main Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants