Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove emotion + stacks UI #4164

Closed
pete-watters opened this issue Sep 1, 2023 · 3 comments · Fixed by #4178 or #4213
Closed

Chore: Remove emotion + stacks UI #4164

pete-watters opened this issue Sep 1, 2023 · 3 comments · Fixed by #4178 or #4213
Labels
effort:large Expected to take over 1 week of integration work

Comments

@pete-watters
Copy link
Contributor

This task is to track work on refactoring out:

  • emotion now we have panda
  • stacks UI
@pete-watters pete-watters self-assigned this Sep 1, 2023
@pete-watters pete-watters added the effort:large Expected to take over 1 week of integration work label Sep 1, 2023
@pete-watters
Copy link
Contributor Author

pete-watters commented Sep 8, 2023

I made some good progress here and have some PRs open.

  1. Phase 1 - remove emotion: chore: emotionless #4178
  2. Phase 2 - remove Stacks UI theme provider - chore: take out Stacks UI theme provider #4179
  3. Phase 3 - remove stacks ui utils - chore: stacks UI utils removal #4180
  4. Phase 4 - get rid of all the Stacks UI we can - chore: stacks UI lib removal #4196

Phase 1 doesn't impact the UI much, phase 2 we start seeing some strange issues and will need to add our own CSS to fix them.

I think it makes sense to rip out all these old styles now, then implement the new container patterns more cleanly.

In Phase 4 we need to port some code from stacks ui / replace with radix. We may decide to do this over a longer time based on priorities but I think it could be good to get it all out ASAP so we have a solid foundation for moving forward with an organised mono-repo and mobile app.

kyranjamie pushed a commit that referenced this issue Sep 18, 2023
## [6.6.0](v6.5.1...v6.6.0) (2023-09-18)

### Features

* create new test acc ([f14e3f1](f14e3f1))
* increase fee actions ([7a9298b](7a9298b))
* ui changes in inscription flow ([23ab7f0](23ab7f0))
* update panda, node ([ddde3b1](ddde3b1))

### Bug Fixes

* add fill=currentColor to refresh icon for dark mode, closes [#4195](#4195) ([25476e7](25476e7))
* adjust header background colour based on screen context, [#4164](#4164) ([015c4e1](015c4e1))
* discord webhook, new org secret ([fbc1c57](fbc1c57))
* firefox publish issue ([e143172](e143172))
* fix fund test try ([2a5d421](2a5d421))
* flaky settings test ([51c460e](51c460e))
* global bg style ([d639c8f](d639c8f))
* pr ext build link ([126b1e7](126b1e7))
* remove radix layout components ([029e6b9](029e6b9))
* remove undefined tokens ([e1b431f](e1b431f))
* script type unknown ([2e344ec](2e344ec))
* stop sign in panel stretching too much, closes [#4212](#4212) ([1804f49](1804f49))
* triger release ([483f0ae](483f0ae))
* triger release ([5cb9193](5cb9193))
* trigger release ([108e74e](108e74e))
* trigger release ([cefd605](cefd605))
* trigger release ([8d596ae](8d596ae))
* trigger release ([316c67a](316c67a))

### Internal

* fund test migrate, closes [#4187](#4187) ([1375cd5](1375cd5))
* migrate network tests, closes [#3707](#3707) ([8ed7553](8ed7553))
* migrate tx requests tests to playwright, closes [#4151](#4151) ([c15b223](c15b223))
* pass all sighashTypes to signer ([fdb06cf](fdb06cf))
* remove emotion, configure panda to load css globally, ditch stacks-ui base, [#4164](#4164) ([d8655c1](d8655c1))
* remove legacy fund selectors ([92a495c](92a495c))
* remove legacy settings selectors ([e6eecb6](e6eecb6))
* remove test env ([61634d4](61634d4))
* rename leaf to leather ([66d159e](66d159e))
* request feature link ([4e6c09d](4e6c09d))
* settings legacy test ([068d3cd](068d3cd))
* swaps ui with leather-styles ([4884fc5](4884fc5))
* update to leather url paths ([203fad5](203fad5))
@pete-watters
Copy link
Contributor Author

@mica000 @fabric-8 - this is the main task for the foundational work I need to implement.

As part of this I will implement:

@pete-watters
Copy link
Contributor Author

We achieved this task last year - removing emotion + stacks UI

pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
## [6.6.0](leather-io/extension@v6.5.1...v6.6.0) (2023-09-18)

### Features

* create new test acc ([f14e3f1](leather-io@f14e3f1))
* increase fee actions ([7a9298b](leather-io@7a9298b))
* ui changes in inscription flow ([23ab7f0](leather-io@23ab7f0))
* update panda, node ([ddde3b1](leather-io@ddde3b1))

### Bug Fixes

* add fill=currentColor to refresh icon for dark mode, closes [leather-io#4195](leather-io#4195) ([25476e7](leather-io@25476e7))
* adjust header background colour based on screen context, [leather-io#4164](leather-io#4164) ([015c4e1](leather-io@015c4e1))
* discord webhook, new org secret ([fbc1c57](leather-io@fbc1c57))
* firefox publish issue ([e143172](leather-io@e143172))
* fix fund test try ([2a5d421](leather-io@2a5d421))
* flaky settings test ([51c460e](leather-io@51c460e))
* global bg style ([d639c8f](leather-io@d639c8f))
* pr ext build link ([126b1e7](leather-io@126b1e7))
* remove radix layout components ([029e6b9](leather-io@029e6b9))
* remove undefined tokens ([e1b431f](leather-io@e1b431f))
* script type unknown ([2e344ec](leather-io@2e344ec))
* stop sign in panel stretching too much, closes [leather-io#4212](leather-io#4212) ([1804f49](leather-io@1804f49))
* triger release ([483f0ae](leather-io@483f0ae))
* triger release ([5cb9193](leather-io@5cb9193))
* trigger release ([108e74e](leather-io@108e74e))
* trigger release ([cefd605](leather-io@cefd605))
* trigger release ([8d596ae](leather-io@8d596ae))
* trigger release ([316c67a](leather-io@316c67a))

### Internal

* fund test migrate, closes [leather-io#4187](leather-io#4187) ([1375cd5](leather-io@1375cd5))
* migrate network tests, closes [leather-io#3707](leather-io#3707) ([8ed7553](leather-io@8ed7553))
* migrate tx requests tests to playwright, closes [leather-io#4151](leather-io#4151) ([c15b223](leather-io@c15b223))
* pass all sighashTypes to signer ([fdb06cf](leather-io@fdb06cf))
* remove emotion, configure panda to load css globally, ditch stacks-ui base, [leather-io#4164](leather-io#4164) ([d8655c1](leather-io@d8655c1))
* remove legacy fund selectors ([92a495c](leather-io@92a495c))
* remove legacy settings selectors ([e6eecb6](leather-io@e6eecb6))
* remove test env ([61634d4](leather-io@61634d4))
* rename leaf to leather ([66d159e](leather-io@66d159e))
* request feature link ([4e6c09d](leather-io@4e6c09d))
* settings legacy test ([068d3cd](leather-io@068d3cd))
* swaps ui with leather-styles ([4884fc5](leather-io@4884fc5))
* update to leather url paths ([203fad5](leather-io@203fad5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment