Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase hardcoded fee for swaps #4984

Closed
fbwoolf opened this issue Feb 26, 2024 · 1 comment · Fixed by #5104
Closed

Increase hardcoded fee for swaps #4984

fbwoolf opened this issue Feb 26, 2024 · 1 comment · Fixed by #5104
Assignees
@fbwoolf
Labels
area:swaps bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Milestone
Fix urgent bugs

Comments

@fbwoolf
Copy link
Contributor

fbwoolf commented Feb 26, 2024

Users are reporting our hardcoded fee for swaps is set too low and often txs are not getting through. We can temporarily 'fix' this by hardcoding a higher fee until we can revisit swap fees with the UX work.
@fbwoolf fbwoolf added the bug-p2 Critical functionality broken for few users, with no clear workarounds label Feb 26, 2024
@markmhendrickson
Copy link
Collaborator

I'm seeing 0.75 STX recommended via app-based flow for ALEX swaps so perhaps 1 STX is a safe hardcode for now.

image

@markmhendrickson markmhendrickson added bug Functionality broken area:swaps labels Feb 26, 2024
@markmhendrickson markmhendrickson added this to the Fix urgent bugs milestone Mar 15, 2024
fbwoolf added a commit that referenced this issue Mar 19, 2024
@fbwoolf
fix: increase swap hardcoded fee, closes #4984
260d206
@fbwoolf fbwoolf linked a pull request Mar 19, 2024 that will close this issue
fix: increase swap hardcoded fee, closes #4984 #5104
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@fbwoolf
fix: increase swap hardcoded fee, closes #4984
1eb268e
@fbwoolf fbwoolf mentioned this issue Mar 26, 2024
Merged
kyranjamie pushed a commit that referenced this issue Mar 26, 2024
@semantic-release-bot
chore(release): 6.32.0
b590877 
## [6.32.0](v6.31.0...v6.32.0) (2024-03-26)

### Features

* add blockstream and hiro api rate limiters, closes [#4926](#4926) ([b1b2ec5](b1b2ec5))

### Bug Fixes

* add new test for sign psbt ([d5d7cb7](d5d7cb7))
* add test for psbt wrong index failure ([7ec9744](7ec9744))
* client side nested button error ([c800721](c800721))
* increase swap hardcoded fee, closes [#4984](#4984) ([1eb268e](1eb268e))
* index bug and modify tests ([f9efae6](f9efae6))
* input payment type, closes [#5076](#5076) ([5f558da](5f558da))
* missing regtest prefix in address check ([7e8549f](7e8549f))
* modify input payment type index for ledger also ([17f57f3](17f57f3))
* swap arrow icon ([9dcd980](9dcd980))
* swap duplicate toast, closes [#5068](#5068) ([5f08a9c](5f08a9c))
* swapping welsh with alex sdk, closes [#5022](#5022) ([1f1216c](1f1216c))
* validation regtest addresses ([462ab8c](462ab8c))

### Internal

* add chromatic visual tests ([3ed207f](3ed207f))
* fix audit vulnerability ([f577570](f577570))
* post-release merge back ([7ad58b1](7ad58b1))
* update link to fee info ([0d0dc34](0d0dc34))
* update link to nonce info ([c79ddda](c79ddda))
* upgrade signer packages ([9ddea5f](9ddea5f))
* upgrade storybook ([fb0ed2a](fb0ed2a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
area:swaps bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
Fix urgent bugs
Development

Successfully merging a pull request may close this issue.

fix: increase swap hardcoded fee, closes #4984 leather-io/extension
2 participants
@markmhendrickson @fbwoolf