Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate tx requests tests to playwright, closes #4151 #4175

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Sep 4, 2023

Try out this version of the Leather — download extension builds.

Migrates the transaction request tests to playwright.

Also, moved some selectors here out of TestAppSelectors. cc @alter-eggo, what do you think? I feel like only selectors being used in the test-app should be located there? Now, UpdateProfileRequestSelectors?

@fbwoolf fbwoolf force-pushed the refactor/migrate-tx-request-tests branch from 8332e0c to cb83a8b Compare September 4, 2023 19:07
@fbwoolf fbwoolf linked an issue Sep 4, 2023 that may be closed by this pull request
@fbwoolf fbwoolf marked this pull request as draft September 4, 2023 20:32
@fbwoolf fbwoolf force-pushed the refactor/migrate-tx-request-tests branch from cb83a8b to 4294728 Compare September 5, 2023 14:49
@fbwoolf fbwoolf marked this pull request as ready for review September 5, 2023 15:01
@fbwoolf fbwoolf force-pushed the refactor/migrate-tx-request-tests branch from 4294728 to c4a7e7c Compare September 5, 2023 17:15
@fbwoolf fbwoolf added this pull request to the merge queue Sep 5, 2023
Merged via the queue into dev with commit c15b223 Sep 5, 2023
@fbwoolf fbwoolf deleted the refactor/migrate-tx-request-tests branch September 5, 2023 18:14
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate transactions test to playwright
3 participants