feat(ui): better bundle size with esmodules #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blockstack UI DocumentationThe Blockstack UI docs have been deployed with Vercel using the code from this PR! Built with commit 6c6baea. |
Deploy previewsDeploy previews for blockstack-app and blockstack-test-app are ready! Built with commit 6c6baea. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4092eb3:
|
kyranjamie
approved these changes
Jul 23, 2020
aulneau
force-pushed
the
feat/rollup-changes-ui
branch
from
5bd9052
to
4092eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
I was doing some work optimizing the bundle size of the docs site and kept seeing that all of the UI library was being bundled in with the application, and I know that we are using esmodules for the site, which I thought would lead to tree-shaking of any component not used. This was not the case.
After digging into it, I found that rollup (which TSDX uses under the hood) offers an option for
preserveModuleswhich will let us output all of the components to their own folder underdist/. This has given us a good amount of savings on the docs site of ~46kb 🗡️ 🔥 You can read a good thread about this here.Before:
After