refactor: add bstk jwt payload validation #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy previewsDeploy previews for blockstack-app and blockstack-test-app are ready! Built with commit f1deb1e. |
hstove
approved these changes
Nov 10, 2020
|
Is this ready to merge or should we pass to QA? |
|
@timstackblock needs authentication smoke test |
|
Double blockstack logo regression in this build, please fix and move back to QA
|
|
The logo fix was merged 5 days with #629 whereas this PR was spun up 14 days ago, so I presume it's simply a matter of rebasing master into this branch and smoke testing again. @kyranjamie mind doing that and assigning back to @timstackblock ? |
kyranjamie
force-pushed
the
feat/use-validation-check
branch
from
02ee249 to
dcc635c
Compare
|
Rebased. |
|
Closing - new PR is #752 , which has the same code but in the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we should add payload validation. Thinking there may be a schema in auth to validate against, realised there's a validation function exposed by the library itself.