Skip to content

Commit

Permalink
fix: release-please use node workspaces plugin + rollback action to v3
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarkhanzadian committed May 17, 2024
1 parent 45d2ded commit f7eb8a0
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 10 deletions.
26 changes: 17 additions & 9 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,25 @@ jobs:
outputs:
releases_created: ${{ steps.release.outputs.releases_created }}
steps:
- uses: google-github-actions/release-please-action@v4
id: release
- uses: google-github-actions/release-please-action@v3
with:
# this assumes that you have created a personal access token (PAT)
command: manifest
token: ${{ secrets.LEATHER_BOT }}
# optional. customize path to release-please-config.json
config-file: release-please-config.json
# optional. customize path to .release-please-manifest.json
manifest-file: .release-please-manifest.json
# Our target branch should be `dev`
target-branch: dev
default-branch: dev

# TODO: get this back when release-please-action@4 gets an update for pnpm node workspaces.
# steps:
# - uses: google-github-actions/release-please-action@v4
# id: release
# with:
# # this assumes that you have created a personal access token (PAT)
# token: ${{ secrets.LEATHER_BOT }}
# # optional. customize path to release-please-config.json
# config-file: release-please-config.json
# # optional. customize path to .release-please-manifest.json
# manifest-file: .release-please-manifest.json
# # Our target branch should be `dev`
# target-branch: dev

# The logic below handles the npm publication:
deploy:
Expand Down
7 changes: 6 additions & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,10 @@
"draft": false,
"prerelease": false
}
}
},
"plugins": [
{
"type": "node-workspace"
}
]
}

0 comments on commit f7eb8a0

Please sign in to comment.