Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis builds #103

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix Travis builds #103

wants to merge 9 commits into from

Conversation

kylefleming
Copy link

@kylefleming kylefleming commented Nov 6, 2019

This PR does the following:

  • Upgrades Travis's macOS image to use Xcode 10.2 to add support for Swift 4.2 and 5. This is because the latest version of Lottie (which is used in the tests) requires Swift 4.2 support. Xcode 10 adds support for Swift 4.2 and Xcode 10.2 adds support for Swift 5.
  • Specifies RxCocoa 4.x in the tests. There appears to be incompatibilities somewhere in the tests with RxCocoa 5, at least on my machine, using Xcode 11.1. I believe sticking to RxCocoa 4.x will alleviate the issue.
  • Fixes a number of issues with the Travis CI environment, including:
    • Setting the gemfile to test/Gemfile (so the correct gems are installed/used)
    • Allowing Bundler 2.x
    • Running pod setup (so the default repo is installed and updated)
    • Unsetting the CPATH environment variable (For some reason this variable is set by Travis, but is set to the macOS SDK which causes issues with xcodebuild).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant