Homework9 #337
Open
Homework9 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the delay in submitting this. I had a lot of trouble unpacking how to do the for loop for the testing/training data in Assignment 1, and I finally think I really understand it. Thanks for this assignment -- it helped clarify things, and forced me to really understand the code. I put some annotations into my code to explain why I did the things I did, and I hope it can partially justify the tardiness.
Re: Assignment 3 --
The code is very interesting. I do think this is relevant to stories I could do in the future and, in fact, I think I've heard of journalists doing something similar – either to mine a huge set of emails etc., or to sift through a sudden document dump quickly. I wonder how much manual clean up there would have to be after running the code (if there is no standardization in how the bills are titled, etc.).
The code makes sense, definitely from a high level, and most of it also from a practical/doable level (though I would like to learn more about the encoder/vectorizer parts).