Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure migration files have different prefixes #13

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Ensure migration files have different prefixes #13

merged 1 commit into from
Nov 28, 2019

Conversation

kusakusakusa
Copy link
Contributor

Hihi,

The previous PR #11 introduced a 'ActiveRecord/DuplicateMigrationVersionError' bug as the 2 migration files generated bear the same prefixes.

@coveralls
Copy link

coveralls commented Nov 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 99.95% when pulling bdc635c on Vic-L:fix/DuplicateMigrationVersionError into 12c642d on ledermann:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 99.947% when pulling bdc635c on Vic-L:fix/DuplicateMigrationVersionError into 12c642d on ledermann:master.

@ledermann ledermann merged commit f534345 into ledermann:master Nov 28, 2019
@ledermann
Copy link
Owner

Great work, thank you!

@kusakusakusa kusakusakusa deleted the fix/DuplicateMigrationVersionError branch November 29, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kusakusakusa @coveralls @ledermann