Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 compatibility #15

Closed
wants to merge 1 commit into from
Closed

Rails 4 compatibility #15

wants to merge 1 commit into from

Conversation

maletor
Copy link

@maletor maletor commented Mar 12, 2013

attr_accessible is extracted out of Rails into a gem.

`attr_accessible` is extracted out of Rails into a gem.
@ledermann
Copy link
Owner

Thanks for this pull request. I'm interested to make the gem work with Rails 4. but removing attr_accessible breaks compatibility with Rails 3, see #7. In addition, Rails 4 should be tested with Travis. Currently, there are some tests failing if running with Rails 4.

@ledermann
Copy link
Owner

In the meantime I have created a new pull request (#16). It still needs some work, so I don't want to merge it into master, yet.

@ledermann ledermann closed this Mar 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants