Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Readable.readable_parent to consider all ancestors #81

Merged

Conversation

meacuna
Copy link
Contributor

@meacuna meacuna commented Mar 21, 2017

Fixes #82

@meacuna meacuna mentioned this pull request Mar 21, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1953ed5 on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@ledermann
Copy link
Owner

Great improvement! Could you a test to verify that the change works?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e1ab77c on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@meacuna
Copy link
Contributor Author

meacuna commented Mar 22, 2017

@ledermann I pushed some modifications to the test suite you had to include the changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-35.0%) to 65.049% when pulling ca2cdb9 on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@ledermann ledermann merged commit 26f0432 into ledermann:master Mar 23, 2017
@ledermann
Copy link
Owner

@meacuna Merged, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants