-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various ADRs about the use of state machines #7770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the things that might help newcomers to LedgerSMB would be a link to the PR for some code that shows how the implementation was done in LSMB. That might be the first implementation, if it was done right the first time, or a later implementation, if it serves as a better example.
In this case, implementation means how existing code was changed to utilize robot3 or how a new view or component was implemented using robot3.
Rather than have a status date of 'Unknown' which provides no useful implementation, how about considering 'Prior to 4 Dec 2023' or a less specific guess, like '2009'. Another example 'between 2014 and 2015', or with 'LSMB release 1.6'. Any way that we can get more context is good. Right now it does not matter, but this will provide better insight in 10 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts...
c000eac
to
c3fac2e
Compare
Added @neilt's suggestion in a new issue. |
Before merging: