Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual feedback of payment line being unapproved #7777

Merged

Conversation

ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Dec 5, 2023

Payment lines which are part of a payment batch may be unapproved even if the transaction itself is approved.

@ehuelsmann ehuelsmann marked this pull request as draft December 5, 2023 22:50
@ehuelsmann
Copy link
Member Author

Initial feedback from @neilt : can we have a column indicating approval status instead of this color which isn't in any legenda anywhere?

Payment lines which are part of a payment batch may be
unapproved even if the transaction itself *is* approved.

The fact that nothing indicates a line may be unapproved,
means that the user will be in confusion as to why the
transaction isn't marked (partially) 'paid' in the
outstanding report.
Accomodates the color blind by using a timer clock icon as well
@ehuelsmann ehuelsmann force-pushed the feature/aa-unapproved-payment-line branch from 39f0678 to 94ea1ba Compare December 6, 2023 18:26
@ehuelsmann ehuelsmann force-pushed the feature/aa-unapproved-payment-line branch from 94ea1ba to 31b6caa Compare December 6, 2023 18:48
@ehuelsmann ehuelsmann marked this pull request as ready for review December 6, 2023 18:58
@ehuelsmann ehuelsmann enabled auto-merge (squash) December 6, 2023 18:59
@ehuelsmann ehuelsmann merged commit b6984d4 into ledgersmb:master Dec 6, 2023
22 checks passed
@ehuelsmann ehuelsmann deleted the feature/aa-unapproved-payment-line branch December 6, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add consistency check to show that payment lines are not posted/approved
1 participant