This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Added struct to hold bor sprints in numeric order #1038
Merged
+91
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 6, 2023
This checking replaces the config processing for bor sprints which has the following issues: 1. It uses string ordering for blocks which is lexical so does not handle decimal scale when sorting numbers 2. It parses the config map every calculation - which is expensive relative to just checking the index order This is likely not an issue for the existing main net as the map only has 2 entries and their sort order is coincidentally the same for both lexical and numeric ordering. Performance is likely also a non issue compared to the other processing during execution flow. These changes are intended to support tx indexing where in the snapshotting process the calc will get called at least twice for each bor block during 1000's of iterations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checking replaces the config processing for bor sprints which has the following issues:
This is likely not an issue for the existing main net as the map only has 2 entries and their sort order is coincidentally the same for both lexical and numeric ordering. Performance is likely also a non issue compared to the other processing during execution flow.
These changes are intended to support tx indexing where in the snapshotting process the calc will get called at least twice for each bor block during 1000's of iterations.