Optionally render page

[skizzo]

Which OS ?

iOS & Android, doesn't matter.

Version

• react-native-swiper v1.5.13 & v1.6.0@nightly.1
• react-native v0.57.8

Expected behaviour

A page that should be optionally rendered doesn't show up at all and reduces the total amount of pages to one less than if optional page is rendered.

Actual behaviour

An empty page is shown, but the slide should be skipped completely.

Steps to reproduce

<Swiper {...swiperProps}>

  <View style={stylePage}>
    <Text>Page 1 (always)</Text>
  </View>

  <View style={stylePage}>
    <Text>Page 2 (always)</Text>
  </View>

  { renderPage3 && // if this is set to "false", an empty page is shown
    <View style={stylePage}>
      <Text>Page 3 (optional)</Text>
    </View>
  } 

  <View style={stylePage}>
    <Text>Page 4 (always)</Text>
  </View>

</Swiper>

[ArrayZoneYour]

Can you reproduce it on v1.6.0@nightly.1 ?

[skizzo]

Yup, same thing with with v1.6.0@nightly.1.

[skizzo]

It makes no difference what props I put, the issue can be reproduced with the exact code I posted originally. Also, I'm sure you can imagine what an "empty page" looks like without adding a gif ;)

const stylePage = {
  flex: 1, 
  alignItems: "center", 
  justifyContent: "center", 
}

Thanks for investigating!

[ArrayZoneYour]

@skizzo It is a missing feature, I will try to support it in this week : )

[skizzo]

You the man, thanks a lot!

[ArrayZoneYour]

@skizzo You can test it on react-native-swiper@1.6.0-dev.1 👀

[skizzo]

Thanks, but it's still showing an empty page..

[ArrayZoneYour]

🤔Have you installed the new version v1.6.0-dev.1 ?

[skizzo]

My bad, my npm install didn't properly update the package. It works like a charm, thanks so much!

[ArrayZoneYour]

The logic of updating the current index also has some problem (when the index of the page which you want to remove is less than current index ), I will fix it in next nightly version.😄