Skip to content

1.2.6.7 does not work with PHP 8.2 #328

Closed as not planned
Closed as not planned
@onkobu

Description

@onkobu

Describe the bug
PHP 8.2 deprecated dynamic properties. This is used in index.php and leads to errors.

Version of PLA
1.2.6.7, https://packages.gentoo.org/packages/net-nds/phpldapadmin

To Reproduce
Run with PHP 8.2 and visit index.php

Deprecated: Creation of dynamic property page::$index is deprecated in /var/www/localhost/htdocs/phpldapadmin/lib/page.php on line 38

Deprecated: Creation of dynamic property page::$sysmsg is deprecated in /var/www/localhost/htdocs/phpldapadmin/lib/page.php on line 468

Deprecated: Creation of dynamic property page::$_block is deprecated in /var/www/localhost/htdocs/phpldapadmin/lib/page.php on line 241

Expected behavior
Simply works.

Screenshots

All it takes is adding properties along the error messages like the following (/phpldapadmin/1.2.6.7/htdocs/lib/page.php):

class page {
  //…

  protected $index;
  
  protected $sysmsg;

  protected $_block;

  public function __construct(…

This includes $askcontainer in /phpldapadmin/1.2.6.7/htdocs/lib/Template.php, despite magic comment it seems no longer used. (Stems from the XML templat)

Metadata

Metadata

Assignees

No one assigned

    Labels

    oldOld version of PLA, may not be fixed.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions