Skip to content

php 8.2+ deprecated issues #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

php 8.2+ deprecated issues #281

wants to merge 4 commits into from

Conversation

suprune20
Copy link

  • PHP 8.2+: Dynamic Properties are deprecated, fix
  • PHP 8.2+: mhash() deprecated, fix

@suprune20 suprune20 closed this Jan 13, 2025
@suprune20 suprune20 reopened this Jan 13, 2025
@andypost
Copy link

checked with PHP 8.4

/var/www/html # find . -type f -name '*.php' -exec php -l {} \;
No syntax errors detected in ./hooks/functions/example.php
No syntax errors detected in ./app/Providers/AppServiceProvider.php
No syntax errors detected in ./app/Http/Requests/ImportRequest.php
No syntax errors detected in ./app/Http/Requests/EntryRequest.php
No syntax errors detected in ./app/Http/Controllers/Auth/LoginController.php
No syntax errors detected in ./app/Http/Controllers/Controller.php
No syntax errors detected in ./app/Http/Controllers/APIController.php
No syntax errors detected in ./app/Http/Controllers/HomeController.php
No syntax errors detected in ./app/Http/Middleware/ApplicationSession.php
No syntax errors detected in ./app/Http/Middleware/SwapinAuthUser.php
No syntax errors detected in ./app/Http/Middleware/CheckUpdate.php
No syntax errors detected in ./app/Traits/MD5Updates.php
No syntax errors detected in ./app/View/Components/Attribute.php
No syntax errors detected in ./app/View/Components/AttributeType.php
No syntax errors detected in ./app/helpers.php
No syntax errors detected in ./app/Ldap/LdapUserRepository.php
PHP Deprecated:  App\Ldap\Rules\LoginObjectclassRule::passes(): Implicitly marking parameter $model as nullable is deprecated, the explicit nullable type must be used instead in ./app/Ldap/Rules/LoginObjectclassRule.php on line 17

Deprecated: App\Ldap\Rules\LoginObjectclassRule::passes(): Implicitly marking parameter $model as nullable is deprecated, the explicit nullable type must be used instead in ./app/Ldap/Rules/LoginObjectclassRule.php on line 17
No syntax errors detected in ./app/Ldap/Rules/LoginObjectclassRule.php
PHP Deprecated:  App\Ldap\Connection::__construct(): Implicitly marking parameter $ldap as nullable is deprecated, the explicit nullable type must be used instead in ./app/Ldap/Connection.php on line 11

Deprecated: App\Ldap\Connection::__construct(): Implicitly marking parameter $ldap as nullable is deprecated, the explicit nullable type must be used instead in ./app/Ldap/Connection.php on line 11
No syntax errors detected in ./app/Ldap/Connection.php
No syntax errors detected in ./app/Ldap/Guard.php
No syntax errors detected in ./app/Ldap/User.php
No syntax errors detected in ./app/Ldap/Entry.php
No syntax errors detected in ./app/Exceptions/InvalidUsage.php
No syntax errors detected in ./app/Exceptions/Import/VersionException.php
No syntax errors detected in ./app/Exceptions/Import/ObjectExistsException.php
No syntax errors detected in ./app/Exceptions/Import/GeneralException.php
No syntax errors detected in ./app/Exceptions/Import/AttributeException.php
No syntax errors detected in ./app/Classes/LDAP/Attribute.php
No syntax errors detected in ./app/Classes/LDAP/Import.php
No syntax errors detected in ./app/Classes/LDAP/Export/LDIF.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Binary/JpegPhoto.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/ObjectClass.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/DN.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/SubschemaSubentry.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/UUID.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/CSN.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/HasSubordinates.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/StructuralObjectClass.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Internal/Timestamp.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Schema.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Schema/OID.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Schema/Mechanisms.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Factory.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Binary.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/Password.php
No syntax errors detected in ./app/Classes/LDAP/Attribute/GidNumber.php
No syntax errors detected in ./app/Classes/LDAP/Import/LDIF.php
PHP Deprecated:  App\Classes\LDAP\Server::rootDSE(): Implicitly marking parameter $cachetime as nullable is deprecated, the explicit nullable type must be used instead in ./app/Classes/LDAP/Server.php on line 210

Deprecated: App\Classes\LDAP\Server::rootDSE(): Implicitly marking parameter $cachetime as nullable is deprecated, the explicit nullable type must be used instead in ./app/Classes/LDAP/Server.php on line 210
PHP Deprecated:  App\Classes\LDAP\Server::schema(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in ./app/Classes/LDAP/Server.php on line 301

Deprecated: App\Classes\LDAP\Server::schema(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in ./app/Classes/LDAP/Server.php on line 301
No syntax errors detected in ./app/Classes/LDAP/Server.php
No syntax errors detected in ./app/Classes/LDAP/Schema/AttributeType.php
No syntax errors detected in ./app/Classes/LDAP/Schema/ObjectClassAttribute.php
No syntax errors detected in ./app/Classes/LDAP/Schema/ObjectClass.php
No syntax errors detected in ./app/Classes/LDAP/Schema/MatchingRule.php
No syntax errors detected in ./app/Classes/LDAP/Schema/Base.php
No syntax errors detected in ./app/Classes/LDAP/Schema/LDAPSyntax.php
No syntax errors detected in ./app/Classes/LDAP/Schema/MatchingRuleUse.php
No syntax errors detected in ./app/Classes/LDAP/Export.php
No syntax errors detected in ./tests/Feature/LoginTest.php
No syntax errors detected in ./tests/Feature/ExampleTest.php
No syntax errors detected in ./tests/Feature/GetBaseDNTest.php
No syntax errors detected in ./tests/TestCase.php
No syntax errors detected in ./tests/CreatesApplication.php
No syntax errors detected in ./tests/Unit/ExampleTest.php
No syntax errors detected in ./resources/themes/architect/views/auth/login.blade.php
No syntax errors detected in ./resources/themes/architect/views/auth/partials/scripts.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/auth.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/error.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/app.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/contentheader.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/contentfooter.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/scripts.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/htmlheader.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/sidebarmenu.blade.php
No syntax errors detected in ./resources/themes/architect/views/layouts/partials/topmenu.blade.php
No syntax errors detected in ./resources/lang/en/auth.php
No syntax errors detected in ./resources/lang/en/validation.php
No syntax errors detected in ./resources/lang/en/pagination.php
No syntax errors detected in ./resources/lang/en/passwords.php
No syntax errors detected in ./resources/views/home.blade.php
No syntax errors detected in ./resources/views/errors/599.blade.php
No syntax errors detected in ./resources/views/errors/555.blade.php
No syntax errors detected in ./resources/views/errors/401.blade.php
No syntax errors detected in ./resources/views/errors/597.blade.php
No syntax errors detected in ./resources/views/errors/598.blade.php
No syntax errors detected in ./resources/views/components/attribute.blade.php
No syntax errors detected in ./resources/views/components/attribute-type.blade.php
No syntax errors detected in ./resources/views/components/attribute/widget/options.blade.php
No syntax errors detected in ./resources/views/components/attribute/binary/jpegphoto.blade.php
No syntax errors detected in ./resources/views/components/attribute/schema/mechanisms.blade.php
No syntax errors detected in ./resources/views/components/attribute/schema/oid.blade.php
No syntax errors detected in ./resources/views/components/attribute/objectclass.blade.php
No syntax errors detected in ./resources/views/components/attribute/layout.blade.php
No syntax errors detected in ./resources/views/components/attribute/internal/timestamp.blade.php
No syntax errors detected in ./resources/views/components/attribute/password.blade.php
No syntax errors detected in ./resources/views/components/attribute/internal.blade.php
No syntax errors detected in ./resources/views/layouts/dn.blade.php
No syntax errors detected in ./resources/views/fragment/schema/attributetypes.blade.php
No syntax errors detected in ./resources/views/fragment/schema/matchingrules.blade.php
No syntax errors detected in ./resources/views/fragment/schema/ldapsyntaxes.blade.php
No syntax errors detected in ./resources/views/fragment/schema/objectclasses.blade.php
No syntax errors detected in ./resources/views/fragment/export.blade.php
No syntax errors detected in ./resources/views/update.blade.php
No syntax errors detected in ./resources/views/frames/import.blade.php
No syntax errors detected in ./resources/views/frames/schema.blade.php
No syntax errors detected in ./resources/views/frames/info.blade.php
No syntax errors detected in ./resources/views/frames/dn.blade.php
No syntax errors detected in ./resources/views/frames/import_result.blade.php
No syntax errors detected in ./resources/views/frame.blade.php
No syntax errors detected in ./resources/views/debug.blade.php
No syntax errors detected in ./database/seeds/DatabaseSeeder.php
No syntax errors detected in ./database/factories/UserFactory.php
No syntax errors detected in ./htdocs/copy_form.php
No syntax errors detected in ./htdocs/export_form.php
No syntax errors detected in ./htdocs/create.php
No syntax errors detected in ./htdocs/add_oclass_form.php
No syntax errors detected in ./htdocs/rename.php
No syntax errors detected in ./htdocs/mass_delete.php
No syntax errors detected in ./htdocs/add_value_form.php
No syntax errors detected in ./htdocs/rename_form.php
No syntax errors detected in ./htdocs/compare_form.php
No syntax errors detected in ./htdocs/query_engine.php
No syntax errors detected in ./htdocs/mass_edit.php
No syntax errors detected in ./htdocs/modify_member_form.php
No syntax errors detected in ./htdocs/template_engine.php
No syntax errors detected in ./htdocs/copy.php
No syntax errors detected in ./htdocs/create_confirm.php
No syntax errors detected in ./htdocs/import.php
No syntax errors detected in ./htdocs/rdelete.php
No syntax errors detected in ./htdocs/entry_chooser.php
No syntax errors detected in ./htdocs/delete_form.php
No syntax errors detected in ./htdocs/compare.php
No syntax errors detected in ./htdocs/delete_attr.php
No syntax errors detected in ./htdocs/password_checker.php
No syntax errors detected in ./htdocs/mass_update.php
No syntax errors detected in ./htdocs/delete.php
No syntax errors detected in ./htdocs/common.php
No syntax errors detected in ./config/cache.php
No syntax errors detected in ./config/auth.php
No syntax errors detected in ./config/session.php
No syntax errors detected in ./config/pla.php
No syntax errors detected in ./config/ldap.php
No syntax errors detected in ./config/app.php
No syntax errors detected in ./config/logging.php
No syntax errors detected in ./public/index.php
No syntax errors detected in ./bootstrap/app.php
No syntax errors detected in ./bootstrap/providers.php
No syntax errors detected in ./routes/web.php
No syntax errors detected in ./routes/api.php
No syntax errors detected in ./routes/channels.php
No syntax errors detected in ./lib/PageRender.php
No syntax errors detected in ./lib/Query.php
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in ./lib/ds_ldap.php on line 901

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in ./lib/ds_ldap.php on line 901
No syntax errors detected in ./lib/ds_ldap.php
No syntax errors detected in ./lib/createlm.php
No syntax errors detected in ./lib/blowfish.php
PHP Deprecated:  set_cached_item(): Optional parameter $subitem declared before required parameter $data is implicitly treated as a required parameter in ./lib/functions.php on line 931

Deprecated: set_cached_item(): Optional parameter $subitem declared before required parameter $data is implicitly treated as a required parameter in ./lib/functions.php on line 931
PHP Deprecated:  draw_jpeg_photo(): Optional parameter $attr_name declared before required parameter $index is implicitly treated as a required parameter in ./lib/functions.php on line 1909

Deprecated: draw_jpeg_photo(): Optional parameter $attr_name declared before required parameter $index is implicitly treated as a required parameter in ./lib/functions.php on line 1909
No syntax errors detected in ./lib/functions.php
No syntax errors detected in ./lib/MassRender.php
No syntax errors detected in ./lib/ds_ldap_pla.php
No syntax errors detected in ./lib/hooks.php
No syntax errors detected in ./lib/QueryRender.php
No syntax errors detected in ./lib/syslog.php
No syntax errors detected in ./lib/config_default.php
No syntax errors detected in ./lib/import_functions.php
No syntax errors detected in ./lib/template_functions.php
No syntax errors detected in ./lib/query_functions.php
PHP Fatal error:  Class ShadowAttribute cannot extend final class Attribute in ./lib/ShadowAttribute.php on line 15

Fatal error: Class ShadowAttribute cannot extend final class Attribute in ./lib/ShadowAttribute.php on line 15
Errors parsing ./lib/ShadowAttribute.php
No syntax errors detected in ./lib/emuhash_functions.php
No syntax errors detected in ./lib/TemplateRender.php
No syntax errors detected in ./lib/ds.php
No syntax errors detected in ./lib/RandomPasswordAttribute.php
No syntax errors detected in ./lib/SambaPasswordAttribute.php
No syntax errors detected in ./lib/Template.php
No syntax errors detected in ./lib/session_functions.php
No syntax errors detected in ./lib/common.php
/var/www/html # php -v
PHP 8.4.2 (cli) (built: Dec 19 2024 04:11:01) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.4.2, Copyright (c) Zend Technologies
    with Zend OPcache v8.4.2, Copyright (c), by Zend Technologies

@williamdes
Copy link

See #202
part of this PR will be refused

@suprune20 suprune20 closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants