Additiona php deprecation fixes for the 1.2 branch. #309
Conversation
Origin: vendor Forwarded: no
Same fix as tecnickcom/TCPDF#734 Origin: vendor Forwarded: no
Uncaught Exception: Serialization of 'SensitiveParameterValue' is not allowed in /usr/share/phpldapadmin/lib/functions.php:645 Origin: vendor Forwarded: no
- Deprecated: Creation of dynamic property page::$index is deprecated in /usr/share/phpldapadmin/lib/page.php on line 38 - Deprecated: Creation of dynamic property page::$sysmsg is deprecated in /usr/share/phpldapadmin/lib/page.php on line 468 - Deprecated: Creation of dynamic property page::$_block is deprecated in /usr/share/phpldapadmin/lib/page.php on line 241 - Creation of dynamic property Template::$askcontainer is deprecated - Creation of dynamic property PLAAttribute::$js is deprecated (on create entry of type Thunderbird) - On import feature - On export feature - And others.. Origin: vendor Forwarded: leenooks#202 Bug-Debian: https://bugs.debian.org/1100771
|
Please submit a Debian Bug and patch for the changes that are not yet in my Debian patches |
|
Sorry, they've been closed and that's why I did not see them.
Considering the comment in #303, I'm afraid you're right on this point.
No I won't: I'm not in the Debian world and have no account/knowledge there. Thanks for your patches. |
|
Thanks for taking the time to address v1.2, however, PLA v1.2 is officially deprecated and no further updates will be applied. All focus is on developing and enhancing v2. |
No worries, I understand. I posted some question about your changes: |
| $t = $server->getContainer($base->getDN()); | ||
| $this->javascript .= sprintf('<input type="hidden" name="container" value="%s" />',htmlspecialchars(is_null($t)? '': $t)); |
There was a problem hiding this comment.
you can use $this->javascript .= sprintf('<input type="hidden" name="container" value="%s" />',htmlspecialchars($server->getContainer($base->getDN() ?? '')));
In what case did you encounter a null value ?
There was a problem hiding this comment.
I want to retain php 5.6 compatibility thus I don't use ??
In what case did you encounter a null value ?
I don't remember. exactly: I wrote it a long time ago and, as PR were not very responsive here, did not submit it.
AFAICR, I was experimenting with a DN component count <= 1.
See
Lines 1066 to 1067 in 3c1f016
Hi Deon,
Here are some commits fixing php 8.x deprecations for the 1.2 branch.
I authored the first one.
The others have been taken from the Fedora official package and I successfully tested them with php 8.3
Thanks for considering this PR.