Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IE 11 #139

Closed
x2764tech opened this issue Mar 3, 2020 · 9 comments
Closed

Support for IE 11 #139

x2764tech opened this issue Mar 3, 2020 · 9 comments

Comments

@x2764tech
Copy link
Contributor

x2764tech commented Mar 3, 2020

Been experimenting with getting this working in IE 11, as we're often plotting masses of data (6 lines of data with ~10K points) and this is the only library I've found that doesn't have the users constantly hitting refresh...
There are a few issues:

I've only got as far as a smoke test, so will update this with any other issues and work-arounds. I'll try to get a pull-request together, as I'd prefer not to have to maintain a fork.

@leeoniya
Copy link
Owner

leeoniya commented Mar 3, 2020

Polyfills for Object.assign and Point2D (currently using core-js and point2d-polyfill) - I consider this a reasonable requirement

Object.assign might be replaced before 1.0 by a custom deep-merge [1], since this would allow better handling of partial options.

Transpilation - currently arrow functions are included in distribution code

not the es5 build: https://github.com/leeoniya/uPlot/blob/master/dist/uPlot.iife.min.js

[1] https://github.com/leeoniya/uPlot/blob/master/src/utils.js#L189

@leeoniya
Copy link
Owner

leeoniya commented Mar 3, 2020

i've switched the regex from /yi to /gi.

@x2764tech
Copy link
Contributor Author

Amazing. Thanks. I'll test this today, but this all looks good.

@x2764tech
Copy link
Contributor Author

Just to confirm, this is great. There is a problem with DPI settings, but it's more than usable for my situation.

@leeoniya
Copy link
Owner

leeoniya commented Mar 4, 2020

There is a problem with DPI setting

odd, since IE11 supports devicePixelRatio.

@leeoniya
Copy link
Owner

leeoniya commented Mar 5, 2020

@x2764tech

Object.assign has been removed.

however, this doesn't mean uPlot has ie11 support. since ie11 does not support the Intl timeZone option [1], any date/time features will always use the browser's local timezone. not sure if that's a dealbreaker in your case, but i expect it would be for many.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat

@x2764tech
Copy link
Contributor Author

Thanks for the update - the lack of timezone support information isn't an issue for me at the moment - most end users are in the UK (which is UTC 1/2 the year), and are used to seeing a graph in UTC time.

Thanks again for the great work

@gMakaan
Copy link

gMakaan commented Mar 22, 2020

Also ie11 has no arrow functions and spread operator support, but uPlot src can be recompiled with babel for legacy browsers

@leeoniya
Copy link
Owner

/dist already has an es5 iife build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants