-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IE 11 #139
Comments
not the es5 build: https://github.com/leeoniya/uPlot/blob/master/dist/uPlot.iife.min.js [1] https://github.com/leeoniya/uPlot/blob/master/src/utils.js#L189 |
i've switched the regex from |
Amazing. Thanks. I'll test this today, but this all looks good. |
Just to confirm, this is great. There is a problem with DPI settings, but it's more than usable for my situation. |
odd, since IE11 supports devicePixelRatio. |
however, this doesn't mean uPlot has ie11 support. since ie11 does not support the Intl [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat |
Thanks for the update - the lack of timezone support information isn't an issue for me at the moment - most end users are in the UK (which is UTC 1/2 the year), and are used to seeing a graph in UTC time. Thanks again for the great work |
Also ie11 has no arrow functions and spread operator support, but uPlot |
/dist already has an es5 iife build |
Been experimenting with getting this working in IE 11, as we're often plotting masses of data (6 lines of data with ~10K points) and this is the only library I've found that doesn't have the users constantly hitting refresh...
There are a few issues:
node_modules/uplot/
in my babel paths, and I'm happy to live with this.[EDIT] core-js tries to patch sticky Regex, but it seems very slow, and, as it stands, causes an infinite loop (see core-js 3.6.0 causes angular downloads to timeout in IE11 zloirock/core-js#754)
[EDIT 2] It might be easier to handle the matching with a global regex or a simpler parser.
I've only got as far as a smoke test, so will update this with any other issues and work-arounds. I'll try to get a pull-request together, as I'd prefer not to have to maintain a fork.
The text was updated successfully, but these errors were encountered: