Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The IRC method #197

Merged
merged 38 commits into from
Mar 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6da4d1c
IRC is now handled with optimize.Optimizer()
hjnpark May 23, 2023
2334816
IRC step in optimizer.step() is fixed. IRC test needs to be added
hjnpark May 26, 2023
a1a22e5
optimize.step() -> optimizer.IRC_step() and optimizer.optimize_step()
hjnpark May 30, 2023
797af27
minor IRC modification
hjnpark May 30, 2023
42efeed
mw wilsonB matrix fixed
hjnpark Jun 2, 2023
5a65bd0
convergence criteria for IRC modified
hjnpark Jun 2, 2023
54d5b2f
IRC will reject a system with no imaginary mode. IRC will print DFT/s…
hjnpark Jun 11, 2023
2ecdda1
evaluateStep for IRC is fixed
hjnpark Jun 11, 2023
bde62c4
minor fix for irc
hjnpark Jun 11, 2023
c3707d8
Adjusting input trust for IRC
hjnpark Jun 14, 2023
11f62c0
minor change for IRC
hjnpark Jun 15, 2023
29b3525
IRC stepsize
hjnpark Jun 16, 2023
8eec8a4
IRC switches to optimizatio near end points
hjnpark Jun 18, 2023
67c8bb8
IRC changes its stepsize based on the quality
hjnpark Jun 27, 2023
663e446
Initial IRC step follows Cartesian vectors from the imaginary mode
hjnpark Jun 30, 2023
fe0559a
IRC step-size varies more conservatively. Its step quality criteria i…
hjnpark Jul 3, 2023
0e2d022
IRC StepState.Poor will be rejected
hjnpark Jul 10, 2023
0bd02ba
IRC poor step is rejected
hjnpark Jul 12, 2023
f849c8f
IRC checks IC when the step quality is bad
hjnpark Jul 12, 2023
6c0a7ee
IRC step evaluation was modified. QCEngine IRC will return a list of …
hjnpark Jul 13, 2023
d964167
minor change in run_json.py
hjnpark Jul 14, 2023
9480491
scipy dependency is added. IRC step quality is less strict
hjnpark Jul 14, 2023
49fb496
IRC update
hjnpark Jul 24, 2023
4837b52
IRC_step() modified
hjnpark Jul 25, 2023
49cee63
IRC second sub step modified
hjnpark Jul 28, 2023
bb442cd
IC Hessian is recalculated when ICs change during IRC
hjnpark Aug 22, 2023
aad0102
Merge branch 'master' of github.com:hjnpark/geomeTRIC
hjnpark Aug 22, 2023
ce945dc
IRC builds a new IC when ICs change starting from the Hx of TS struct…
hjnpark Sep 2, 2023
41e26dc
IRC tested with 500 cases
hjnpark Sep 14, 2023
2635273
pulled leeping/master to hjnpark/master
hjnpark Sep 14, 2023
a364fc3
codecov ignores IRCError
hjnpark Sep 17, 2023
970e37e
irc test updated (smaller stepsize)
hjnpark Sep 21, 2023
e82507f
optimize.py modified to return converged status when Converge_maxiter…
hjnpark Sep 21, 2023
4c1f3c8
pull from lpw/master
hjnpark Mar 15, 2024
d7daaae
Modifications to address PR comments
hjnpark Mar 16, 2024
3297694
Contribution information
hjnpark Mar 17, 2024
2df2771
evaluateStep will call different functions for IRC and optimization.
hjnpark Mar 17, 2024
b2ffb78
minor change
hjnpark Mar 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exclude_lines =
raise NEBChainRespaceError
raise NEBStructureError
raise NEBBandGradientError
raise IRCError
def visualize
verbose:
if verbose >=
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Documentation is hosted at https://geometric.readthedocs.io/ .

Authors: Lee-Ping Wang, Chenchen Song

Contributors: Heejune Park (Nudged elastic band); Yudong Qiu (Psi4 engine, error handling); Daniel G. A. Smith (Testing framework, QCEngine JSON API);
Contributors: Heejune Park (Nudged elastic band, Intrinsic reaction coordinate); Yudong Qiu (Psi4 engine, error handling); Daniel G. A. Smith (Testing framework, QCEngine JSON API);
Tamas K. Stenczel (GitHub Actions, ASE engine); Sebastian Lee (Molpro engine); Chaya Stern (Travis, Conda); Qiming Sun (Custom engine);
Alberto Gobbi (Batch energy/gradient, logging); Josh Horton (Convergence criteria, Gaussian engine); Akhil Shajan (QUICK engine)

Expand Down
4 changes: 2 additions & 2 deletions docs/source/citation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Credits

Authors: Lee-Ping Wang, Chenchen Song

Contributors: Heejune Park (Nudged elastic band); Yudong Qiu (Psi4 engine, error handling); Daniel G. A. Smith (Testing framework, QCEngine JSON API);
Contributors: Heejune Park (Nudged elastic band, Intrinsic reaction coordinate); Yudong Qiu (Psi4 engine, error handling); Daniel G. A. Smith (Testing framework, QCEngine JSON API);
Tamas K. Stenczel (GitHub Actions, ASE engine); Sebastian Lee (Molpro engine); Chaya Stern (Travis, Conda); Qiming Sun (Custom engine);
Alberto Gobbi (Batch energy/gradient, logging); Josh Horton (Convergence criteria, Gaussian engine); Akhil Shajan (QUICK engine)

Expand All @@ -40,7 +40,7 @@ License

Authors: Lee-Ping Wang, Chenchen Song

Contributors: Yudong Qiu, Daniel G. A. Smith, Sebastian Lee, Chaya Stern, Qiming Sun,
Contributors: Heejune Park, Yudong Qiu, Daniel G. A. Smith, Sebastian Lee, Chaya Stern, Qiming Sun,
Alberto Gobbi, Josh Horton, Tamas K. Stenczel, Akhil Shajan

Redistribution and use in source and binary forms, with or without modification,
Expand Down
2 changes: 2 additions & 0 deletions examples/1-simple-examples/hcn_hnc_irc/gaussian/command.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
geometric-optimize start.gjf --irc yes --nt 6 --trust 0.05 --engine gaussian --converge set GAU_LOOSE

10 changes: 10 additions & 0 deletions examples/1-simple-examples/hcn_hnc_irc/gaussian/start.gjf
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
%Mem=4GB
# hf/3-21g Force=NoStep SCF=(XQC, VeryTightLinEq)

Downloaded from PubChem

0 1
C -0.1088783634 -0.6365101639 0.0043221742
N -0.6393457902 0.4205365638 0.0052498438
H 0.7532976101 0.2173493463 -0.0090384631

Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
#==========================================#
#| File containing vibrational modes |#
#| generated by geomeTRIC and |#
#| readable by ForceBalance |#
#| |#
#| Octothorpes are comments |#
#| This file should be formatted like so: |#
#| (Full XYZ file for the molecule) |#
#| Number of atoms |#
#| Comment line |#
#| a1 x1 y1 z1 (xyz for atom 1) |#
#| a2 x2 y2 z2 (xyz for atom 2) |#
#| |#
#| These coords will be actually used |#
#| |#
#| (Followed by vibrational modes) |#
#| Do not use mass-weighted coordinates |#
#| ... |#
#| v (Eigenvalue in wavenumbers) |#
#| dx1 dy1 dz1 (Eigenvector for atom 1) |#
#| dx2 dy2 dz2 (Eigenvector for atom 2) |#
#| ... |#
#| (Empty line is optional) |#
#| v (Eigenvalue) |#
#| dx1 dy1 dz1 (Eigenvector for atom 1) |#
#| dx2 dy2 dz2 (Eigenvector for atom 2) |#
#| ... |#
#| and so on |#
#| |#
#| Please list freqs in increasing order |#
#==========================================#

#
# == Summary of harmonic free energy analysis ==
# Note: Rotational symmetry is set to 1 regardless of true symmetry
# 1 Imaginary Frequencies (cm^-1): 1215.859i
# Note: Free energy does not include contribution from imaginary mode(s)
#
# Free energy contributions calculated at @ 300.00 K:
# Zero-point vibrational energy: 6.5453 kcal/mol
# H (Trans + Rot + Vib = Tot): 1.4904 + 0.8942 + 0.0003 = 2.3849 kcal/mol
# S (Trans + Rot + Vib = Tot): 35.8748 + 16.3847 + 0.0010 = 52.2605 cal/mol/K
# TS (Trans + Rot + Vib = Tot): 10.7624 + 4.9154 + 0.0003 = 15.6782 kcal/mol
#
# Ground State Electronic Energy : E0 = -92.24604266 au ( -57885.2657 kcal/mol)
# Free Energy Correction (Harmonic) : ZPVE + [H-TS]_T,R,V = -0.01075349 au ( -6.7479 kcal/mol)
# Gibbs Free Energy (Harmonic) : E0 + ZPVE + [H-TS]_T,R,V = -92.25679615 au ( -57892.0136 kcal/mol)
#

3
Iteration 0 Energy -92.24604266
C -0.1088783634 -0.6365101639 0.0043221742
N -0.6393457902 0.4205365638 0.0052498438
H 0.7532976101 0.2173493463 -0.0090384631

-1215.858933
-0.043293 -0.081607 0.000849
0.075287 0.009576 -0.000867
-0.530324 0.839319 0.001930

2126.655388
-0.335109 0.647241 0.000681
0.302446 -0.563902 -0.000708
-0.209774 0.123745 0.001723

2451.859833
-0.057515 -0.023525 0.000737
-0.012776 -0.015886 0.000213
0.862859 0.501058 -0.011742
Loading
Loading