Skip to content

show logs meta json if keyword is a filename #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Vigilans
Copy link

Example:
image

@jdneo
Copy link

jdneo commented Apr 27, 2019

What is this for?

@Vigilans
Copy link
Author

To show preview or solution webview, a problem node must be provided.

There are two steps to retrieve the problem node from the text document.

  1. Get meta info from text document.
  2. Get problem node with the id in the meta info.

This PR works on the first step, providing the meta info needed (if we use file path as show keyword).

This is a way to reuse the meta info parsing logic of leetcode-cli, since the logic is so coupled with cli utils that it's hard to extract it to vscode-leetcode.

Another way is to add an option like leetcode meta <filename>, but it will introduce more code.

@Vigilans Vigilans closed this May 8, 2019
@Vigilans Vigilans deleted the vigilans/meta branch May 8, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants