Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hotham renderer #235

Merged
merged 53 commits into from
Jul 5, 2022
Merged

Upgrade Hotham renderer #235

merged 53 commits into from
Jul 5, 2022

Conversation

kanerogers
Copy link
Collaborator

Background

This change is the most significant since Hotham was released. In it, we have:

  • Completely rewritten the rendering backend to use shared buffers and MultiDrawIndirect
  • Performed a large-scale rewrite of the glTF importer
  • Written a new abstraction around vk::Buffer

Overall, I'm really happy with the work, and believe this lays down a solid foundation moving forward.

Next steps

Known bugs

Testing

In order to test this PR, do the following:

  • Run the tests on your local machine with cargo test -p hotham --release -- --test-threads 1
  • Run all the examples on a Quest 2

@kanerogers kanerogers requested review from sinoth and ickk July 5, 2022 01:41
@kanerogers kanerogers self-assigned this Jul 5, 2022
@ickk
Copy link
Contributor

ickk commented Jul 5, 2022

All the examples ran fine on my Quest 2 device, including the stress test!

@kanerogers
Copy link
Collaborator Author

doit

@kanerogers kanerogers merged commit 384556e into main Jul 5, 2022
@kanerogers kanerogers deleted the kanerogers/issue202 branch July 5, 2022 04:45
@kanerogers kanerogers mentioned this pull request Jul 5, 2022
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants