-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] being able to detect all test modules #3
Comments
It's not clear to me what you want to achieve. The basic idea behind these parameters was to have a simple way to select sources. Because of the way how Mill works, a Do you want to exclude Mill modules/targets or do you want to inspect arbitrary Java source file whether they implement some kind of test framework? I'm assuming the former. If you only want to catch more test modules (e.g. when you have test projects, that have other names), it's probably easier to just inspect all modules and detect tests by the fact that they implement It would be nice, if Mill had some way to select modules by type. E.g |
I just opened a PR in Mill that added type filters: com-lihaoyi/mill#2997 After it is merged, we should be able to express exactly the right sources:
|
This prepared mill-jacoco to better catch exactly the correct module sources. It especially detects any custom test module and excludes it's coverage data from the reports. Perviously, we only detected test modules by naming conventions, which was rather sloppy. Fix #3 This feature only works when used with Mill 0.11.7 or newer. This is a soft requirement and will checked at runtime. Pull request: #74
These two lines indicate
mill-jacoco
only support test package intest
name:mill-jacoco/core/src/de/tobiasroeser/mill/jacoco/JacocoReportModule.scala
Lines 58 to 59 in 6e494ef
for other packages
foo extends Tests
orbar extends Tests
cannot be detected by Jacobo.a cursed idea is finding a directory having
testFramework
(or some internal test api) to automatically detect the test packagesThe text was updated successfully, but these errors were encountered: