-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS resource issues with recent changes (0.4.9) #55
Comments
I see readme instructions have changed, will look into that. Will try 0.4.9 and 0.4.8. Edit: pinning to 0.4.8 of the wrapper I don't get the issue. |
I tried to make a reproducible example. https://github.com/IdiosApps/millw-tester/actions/runs/6341629848/job/17225692316. It gets stuck in a loop:
I'll try again with the version specified. Same log spam with Same, with Using 0.4.8, there is no infinite logs: https://github.com/IdiosApps/millw-tester/actions/runs/6341719164/job/17225972414 The lesson for me is to pin to a specific version (of course!). I hope these help resolve the issue :) |
Thank you for this report. I already thought about such an situation just after I've merges PR #51, but later forgot about that "potential issue". The issue is, that we try to use a system-installed mill executable, if installed, but if that executable itself is a millw script trying to use the system-installed mill executable, we have a never ending story. @Flowdalic Looks like we need some checks that the "system" executable we want to ask for it's version is not us, the millw script itself. |
I downgraded the 0.4.9 release to a pre-release and added a note to the changelog. I don't have the bandwidth to fix this issue immediately. Any help would be appreciated. |
@IdiosApps Could you check if the PR fixed the issue for you? |
Summary:
millw (since ~ 1 day ago) appears to:
I'm currently experimenting in CI to try and fix things, but I believe the issue is a recent change in
millw
.This works fine:
This has been having issues, since yesterday:
Even just invoking
--version
gets issues. The issues when using millw are like:On some runs, too many files are left open - which causes issues for future Jenkins jobs running on the same swarm agents. They can fail with some OS tools, python scripts, whatever - anything that wants to read files:
Mostly I've been blowing away the EC2 instance each time to clear things (trying to avoid blowing up my own PC's resources)
The text was updated successfully, but these errors were encountered: