Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt formatOnSave changes #2

Closed
jrieken opened this issue Oct 18, 2016 · 1 comment
Closed

Adopt formatOnSave changes #2

jrieken opened this issue Oct 18, 2016 · 1 comment

Comments

@jrieken
Copy link

jrieken commented Oct 18, 2016

Since version 1.6 VS Code has a format on save option. It works by calling the registered formatting provider for the language in question and most importantly it happens before the file is saved to disk, not causing additional fs writes and event cascades.

Please adopt this code code by either removing it and trusting the new editor.formatOnSave-setting or by using the new onWillSaveTextDocument-event.

See https://code.visualstudio.com/updates#_format-on-save, microsoft/vscode#12449, and microsoft/vscode#239 for more details

@leftstick
Copy link
Owner

Thanks for notifying, updated with trusting editor.formatOnSave option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants