Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include e.toString in error messages #7

Closed
marchage opened this issue May 6, 2018 · 2 comments
Closed

include e.toString in error messages #7

marchage opened this issue May 6, 2018 · 2 comments

Comments

@marchage
Copy link

marchage commented May 6, 2018

Hi,

I just spend some time trying to figure out why esformatter was running as an npm script but not with your extension:

Formating failed, your code is invalid JavaScript

Added a e.toString() to line 84 in src/server/index.ts and got:

Error: Plugin 'esformatter-rename' is not supported. Please consider opening an issue for supporting

which help. Perhaps you should add it should be added.

All the best,

Marc

ps close at your discretion

leftstick added a commit that referenced this issue May 8, 2018
@leftstick
Copy link
Owner

Thanks for reporting the issue, the message Error: Plugin 'esformatter-rename' is not supported. Please consider opening an issue for supporting should be in the notification instead of Formating failed, your code is invalid JavaScript, it used to be. No idea why this feature broke now.

I just fixed this notification issue, and support the plugin esformatter-rename, you can try it now with 1.6.0

@marchage
Copy link
Author

marchage commented Feb 4, 2020

I had forgotten about the extension that really worked for me. But I was able to find it by issue, (and the fact that my activities are not many haha, so "2018" was enough). I'll give it a try. Best wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants