Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backup config from ws to operator #89

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

leg100
Copy link
Owner

@leg100 leg100 commented Feb 3, 2021

Move configuration of backup functionality from individual workspaces, to the operator. I think this makes more sense:

  • One-off configuration at operator install time
  • Backup client and bucket can be validated at install time (previously it would only be validated when a workspace attempt to backup its state for the first time)
  • Limits possible complexity of different workspaces having not only different backup buckets but different backup providers (gcs, s3, etc).

I've also refactored the backup code in preparation for adding support for S3 #88.

@leg100 leg100 merged commit 86450c1 into master Feb 3, 2021
@leg100 leg100 deleted the move-backup-config-to-operator branch February 3, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant