fix: Add missing CancelRunAction to WorkspaceWriteRole #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanli16
changed the title
Members with WorspaceAdminRole cannot manually cancel pending runs in a workspace. This PR adds the missing permission to the role.
juanli16
force-pushed
the
Add-missing-role-permission
branch
from
4793446
to
4cb02f8
Compare
juanli16
changed the title
|
Thanks, much appreciated. |
leg100
pushed a commit
that referenced
this pull request
Dec 5, 2023
🤖 I have created a release *beep* *boop* --- ## [0.2.0](v0.1.18...v0.2.0) (2023-12-05) With the introduction of agent pools, you'll have to not only upgrade `otfd` but any instances of `otf-agent` you have running as well. If you have any agent tokens, or workspaces assigned to use agents, then they are automatically moved over to use a default agent pool. ### ⚠ BREAKING CHANGES * agent pools ([#653](#653)) ### Features * agent pools ([#653](#653)) ([662bfd9](662bfd9)) ### Bug Fixes * Add missing CancelRunAction to WorkspaceWriteRole ([#649](#649)) ([599ddcb](599ddcb)) * docker-compose otfd healthcheck ([c553b58](c553b58)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered the issue that a team member with permission to manage workspace cannot cancel a pending run. This PR adds the missing
CancelRunActionto theWorkspaceWriteRole.