-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RadfordImpurityDensity
model to the SSD extension
#74
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 33.95% 39.67% +5.72%
==========================================
Files 26 27 +1
Lines 1944 2009 +65
==========================================
+ Hits 660 797 +137
+ Misses 1284 1212 -72 ☔ View full report in Codecov by Sentry. |
be0702a
to
875d98f
Compare
This PR does, by default, not read the crystal metadata for the impurity density. |
Last changes (but should be good to go now):
|
@oschulz wants to remove the |
I would also change the default impurity density value (when no crystal metadata is available) to |
Follow-up of #72 (got closed by accident when resolving the merge conflicts)