Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RadfordImpurityDensity model to the SSD extension #74

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

fhagemann
Copy link
Contributor

Follow-up of #72 (got closed by accident when resolving the merge conflicts)

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 59.61538% with 21 lines in your changes missing coverage. Please review.

Project coverage is 39.67%. Comparing base (8e1da65) to head (76d2825).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendDataManagementSolidStateDetectorsExt.jl 59.61% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   33.95%   39.67%   +5.72%     
==========================================
  Files          26       27       +1     
  Lines        1944     2009      +65     
==========================================
+ Hits          660      797     +137     
+ Misses       1284     1212      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor Author

This PR does, by default, not read the crystal metadata for the impurity density.
However, the default value is increased from -1e9cm^-3 to -5e9cm^-3.

@theHenks theHenks added the enhancement New feature or request label Nov 9, 2024
@fhagemann
Copy link
Contributor Author

Last changes (but should be good to go now):

  • Changed the default impurity density to -1e10cm^-3
  • Apply the correct order of magnitude (and sign for p-type) when reading the impurity density data
  • Add tests for the impurity density read-in

@fhagemann
Copy link
Contributor Author

@oschulz wants to remove the LsqFit dependency by including relevant fitting code into this package.

@fhagemann
Copy link
Contributor Author

I would also change the default impurity density value (when no crystal metadata is available) to -0.9e10/cm^3 to match the default value used for fieldgen in LegendGeSim.

@fhagemann fhagemann added the ssd Related to the SolidStateDetectors extension label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ssd Related to the SolidStateDetectors extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants