-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docstrings #80
base: main
Are you sure you want to change the base?
Conversation
6070456
to
23f104a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to (re)introduce two functions (not sure if we want them out):
f_optimize_ctc
and get_n_after_aoe_cut
. Do we need/want them?
The failing tests seem to be unrelated (can we fix that??) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 21.33% 21.33%
=======================================
Files 36 36
Lines 3305 3305
=======================================
Hits 705 705
Misses 2600 2600 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone else should judge the verbosity of the argument descriptions.
Updated docstrings in the following format:
There are still functions that need arguments, keywords, returns or a description added. All of the missing descriptions are found in this Google Doc.
https://docs.google.com/document/d/1-clJFUV2ZZ8kklChEZ_7bfOK89VDA-6_WGYy7SodkRs/edit?usp=sharing