Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstrings #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated docstrings #80

wants to merge 1 commit into from

Conversation

apearsonn
Copy link

@apearsonn apearsonn commented Oct 16, 2024

Updated docstrings in the following format:

"""
function()
Description of function.
 Arguments
- 'x'
- 'y'
- 'z'

 Keywords
- 'x'

 Returns
- 'x'

"""

There are still functions that need arguments, keywords, returns or a description added. All of the missing descriptions are found in this Google Doc.
https://docs.google.com/document/d/1-clJFUV2ZZ8kklChEZ_7bfOK89VDA-6_WGYy7SodkRs/edit?usp=sharing

@theHenks theHenks self-requested a review October 16, 2024 12:13
@theHenks theHenks added the documentation Improvements or additions to documentation label Oct 16, 2024
@fhagemann fhagemann force-pushed the dev branch 5 times, most recently from 6070456 to 23f104a Compare October 30, 2024 17:27
Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to (re)introduce two functions (not sure if we want them out):
f_optimize_ctc and get_n_after_aoe_cut. Do we need/want them?

@fhagemann
Copy link
Contributor

The failing tests seem to be unrelated (can we fix that??)

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.33%. Comparing base (7ff7aac) to head (6d7a596).

Files with missing lines Patch % Lines
src/peakshapes.jl 0.00% 3 Missing ⚠️
src/aoe_cut.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   21.33%   21.33%           
=======================================
  Files          36       36           
  Lines        3305     3305           
=======================================
  Hits          705      705           
  Misses       2600     2600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann changed the base branch from dev to main December 11, 2024 12:11
@fhagemann fhagemann marked this pull request as draft December 12, 2024 13:50
@fhagemann fhagemann marked this pull request as ready for review December 16, 2024 14:47
Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else should judge the verbosity of the argument descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants