Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for yaml files and other updates #57

Merged
merged 13 commits into from
Mar 1, 2024
Merged

Conversation

iguinn
Copy link
Collaborator

@iguinn iguinn commented Mar 1, 2024

  • Added support for yaml files using "safe_load"
  • Made it possible to set coord_grid directly rather than setting period and offset separately
  • The signature and types in kwargs can now be included either through kwargs or as their own json/yaml entries (I may deprecate kwargs at some point)
  • module entry is now unnecessary; instead you can prepend the module to the function name (i.e. dspeed.processors.trap)
  • Fixed a bug that was causing unit conversions to mess up for time coordinates when reading them as outputs
  • Added tests

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 62.83%. Comparing base (293ef8c) to head (f904711).
Report is 4 commits behind head on main.

Files Patch % Lines
src/dspeed/processing_chain.py 64.70% 12 Missing ⚠️
src/dspeed/build_dsp.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   63.05%   62.83%   -0.22%     
==========================================
  Files          46       46              
  Lines        2980     2995      +15     
==========================================
+ Hits         1879     1882       +3     
- Misses       1101     1113      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iguinn iguinn merged commit 14e3632 into legend-exp:main Mar 1, 2024
11 checks passed
@gipert gipert linked an issue Mar 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support YAML configuration files
1 participant