Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed K events parameter #79

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fixed K events parameter #79

merged 2 commits into from
Mar 14, 2023

Conversation

sofia-calgaro
Copy link
Collaborator

@sofia-calgaro sofia-calgaro commented Mar 14, 2023

Simplified the "K events" plotting: now, if you want to plot only those energy events that lie in [1430,1575] keV, you have to build the following subsystem entry:

"subsystems": {       
      "geds": {
          "K events":{
              "parameters": "K_events",
              "event_type": "K_lines",
              "plot_structure": "per string",
              "plot_style" : "scatter"
          }
      }
  }

"cuts": "K lines" is no more needed as it was before (indeed, since we are already specifying with the parameters entry that we want to look at K events, it would be redundant to add also that cut).

The cut over K lines entries is still an option for plotting other parameters in correspondence of K entries. However, it still does not work because in the dataframe the energy column is missing (eg. if we want to plot the baseline in correspondence of K entries, we cannot do it at the moment because the code does not know that it also has to load an energy column, which is needed for applying the energy cut). This problem was already there, and it seems it can be solved by simply loading the additional energy column if "cuts": "K lines" is present for a given parameter.

@sofia-calgaro sofia-calgaro merged commit 47e0218 into legend-exp:dev Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant