-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add routines for computing time coincidence map and evt #51
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 72.30% 69.03% -3.27%
==========================================
Files 23 24 +1
Lines 1607 1686 +79
==========================================
+ Hits 1162 1164 +2
- Misses 445 522 +77 ☔ View full report in Codecov by Sentry. |
) -> Table: | ||
"""Builds a time-coincidence map from a hit of hit data Tables. | ||
|
||
- build an ak.Array of the data merging channels with fields base on "time_name", and "idx_name" and adding a field `rawid` from the channel idx, also add the row (`hit_idx`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please wrap!
Can you calculate how many events you would have to process to make memory usage problematic? |
I think around 10^8 hits over the full detector.
Note: The issue is just when we create the TCM, once we have it we can iterate over it without memory issues. |
I think this can likely be done without loading the full file into memory with a "leap-frog" like reading. Similar to the reboost/src/reboost/build_tcm.py Line 39 in edabe63
|
Alternatively, |
I think we should merge this, since it is still useful functionality, even if some parts have to be changed to work for very large files |
This is still a bit WIP.
Issues:
I still think its useful if @gipert can have a look so we plan what needs to be changed