Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swahili Translations #190

Merged

Conversation

wambugucoder
Copy link
Contributor

@wambugucoder wambugucoder commented Jan 2, 2021

Make sure you go through the Contributing guide.

Please delete options that are not relevant.

Title

This pull request (PR) is made in reference to:

Description

What does this PR do?

Recommendations for how to test this?

Motivation and Context

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Testing

  • My submission passes the tests?
    • If you did additional testing, please describe in detail how you tested your changes
  • I added new tests for core changes, as applicable?

Screenshots (if appropriate):

@welcome
Copy link

welcome bot commented Jan 2, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thank you @wambugucoder 👍

@welcome
Copy link

welcome bot commented Jan 2, 2021

🎉 Congrats on merging your first pull request! 🎉 ❤️ THANK YOU THANK YOU THANK YOU ❤️

We'd love to celebrate you and your contribution to the community. Let us say "Thank You" again, by sending you a special gift only given to special individuals like you who have chosen to give back.
We couldn't thank you enough for your contribution. We hope you continue sharing your gifts and knowledge with not just us, but with the world around you.😍

@madiedgar madiedgar linked an issue Jan 2, 2021 that may be closed by this pull request
5 tasks
@wambugucoder
Copy link
Contributor Author

I'm always happy to help @madiedgar

Copy link

@timsankara timsankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wambugucoder check out these suggestions. I'm open to discuss them.

# << Keywords >>
False: "uwongo"
None: "hakuna"
True: "ukweli"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True: "kweli"

assert: "sisitiza"
async: "async"
await: "ngoja"
break: "vunja"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break: "maliza"

assert: "sisitiza"
async: "async"
await: "ngoja"
break: "vunja"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break: "maliza"

async: "async"
await: "ngoja"
break: "vunja"
class: "darasa"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class : "jumuisho"

break: "vunja"
class: "darasa"
continue: "endelea"
def: "fafanua"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def: "unda"

map: "ramani"
max: "upeo"
memoryview: "mtazamo-wa-kumbukumbu"
min: "kiwango-cha-chini"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min: "ndogo"

pow: "nguvu"
print: "chapisha"
property: "mali"
range: "masafa"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range: "kati"

iter: "mara-kwa-mara"
len: "urefu"
list: "orodha"
locals: "wenyeji"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up for discussion...

globals: "ulimwengu"
hasattr: "ina-sifa"
hash: "hash"
help: "saidia"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help: "usaidizi"

eval: "tathmini"
exec: "tekeleza"
filter: "chuja"
float: "elea"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the meaning of this word be getting lost in translation?

@madiedgar
Copy link
Member

Hey @Sanqqara, these are great suggestions. Could you create a pull request with all your reviews? That was future reviewers can be part of the conversation as well? 👍

Take a look at the Python translation from another language's branch for an example. Let me know if you have any questions!

@timsankara
Copy link

@madiedgar sure I'll be on it.

madiedgar pushed a commit that referenced this pull request Oct 2, 2022
Thank you @wambugucoder for your contribution 🎉
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
Thank you @wambugucoder for your contribution 🎉
@madiedgar madiedgar added this to the Swahili Language Translation milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New Language: Swahili (Python)
4 participants