Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDI authentication authorization in legionctl #313

Closed
kirillmakhonin opened this issue Aug 8, 2018 · 1 comment · Fixed by #705
Closed

Add EDI authentication authorization in legionctl #313

kirillmakhonin opened this issue Aug 8, 2018 · 1 comment · Fixed by #705
Assignees
Labels
feature [Added] for new features. security [Security] to invite users to upgrade in case of vulnerabilities.
Milestone

Comments

@kirillmakhonin
Copy link
Member

kirillmakhonin commented Aug 8, 2018

We need to protect EDI server with dex.
Also we need to add auth functionality to legionctl tool.
Question to discuss: which credentials should be passed to legionctl tool, dex token or plain login and password (legionctl sends it via HTTPS)

Login from local dev should result profile with all required endpoint and credential.

@kirillmakhonin kirillmakhonin added the feature [Added] for new features. label Aug 8, 2018
@kirillmakhonin kirillmakhonin added the security [Security] to invite users to upgrade in case of vulnerabilities. label Aug 14, 2018
kirillmakhonin added a commit that referenced this issue Nov 29, 2018
@dsuslov dsuslov added this to the 0.10.0 milestone Dec 11, 2018
@kirillmakhonin
Copy link
Member Author

As a variant, next flow is possible:

  1. New entity named auth tool has to be added.
  2. auth tool has to operate with DEX directly (not in proxy gate mode)
  3. EDI has to be closed by DEX (in proxy gate mode)
  4. On each remote command legionctl tool can get 401/403 HTTP code in response.
  5. In cases of 401/403 code legionctl has to request auth tool with required scope (e.g. enclave and functions). On response auth tool generates web URL (that is handled by auth) closed by dex.
  6. Client receives this URL in console and, if it is possible, browser opens with URL
  7. Client has to be redirected from URL to DEX (standard way), then redirected back with oauth2 token
  8. auth web view has to display token and try to connect to listened by legionctl local port using standard XHR web request to provide token automatically.

kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
kirillmakhonin added a commit that referenced this issue Dec 27, 2018
mcdoker18 added a commit that referenced this issue Dec 28, 2018
kirillmakhonin added a commit that referenced this issue Dec 28, 2018
mcdoker18 added a commit that referenced this issue Dec 28, 2018
mcdoker18 added a commit that referenced this issue Dec 28, 2018
kirillmakhonin added a commit that referenced this issue Dec 29, 2018
mcdoker18 added a commit that referenced this issue Dec 29, 2018
kirillmakhonin added a commit that referenced this issue Dec 29, 2018
mcdoker18 added a commit that referenced this issue Dec 29, 2018
mcdoker18 added a commit that referenced this issue Dec 29, 2018
mcdoker18 added a commit that referenced this issue Dec 29, 2018
mcdoker18 added a commit that referenced this issue Dec 29, 2018
dsuslov pushed a commit that referenced this issue Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Added] for new features. security [Security] to invite users to upgrade in case of vulnerabilities.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants