Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pylint warnings #686

Closed
mcdoker18 opened this issue Dec 24, 2018 · 1 comment · Fixed by #767
Closed

Fix pylint warnings #686

mcdoker18 opened this issue Dec 24, 2018 · 1 comment · Fixed by #767
Assignees
@botsman
Labels
CI/CD/tests
Milestone
1.0.0

Comments

@mcdoker18
Copy link
Contributor

We observe more 1100 pylint warnings after fixing of linter in the #665 PR.
Warnings: https://cc.epm.kharlamov.biz/jenkins/job/Build_Legion_Artifacts/
Need to fix them.
@mcdoker18 mcdoker18 self-assigned this Dec 29, 2018
@mcdoker18 mcdoker18 added this to the 1.0.0 milestone Dec 29, 2018
@mcdoker18 mcdoker18 assigned botsman and unassigned mcdoker18 Jan 22, 2019
@botsman
Copy link
Member

botsman commented Jan 24, 2019

It seems that our .pylintrc doesn't work, because I can see a lot of warning about line length exceeding 100 symbols though in .pylintrc it is set to 120 symbols.
If we fix it, some amount of warnings should go away. And after that we need to fix the rest.

botsman pushed a commit that referenced this issue Jan 28, 2019
[#686] move .pylintrc to root directory
af040e4
botsman pushed a commit that referenced this issue Jan 28, 2019
[#686] fix high and normal priority pylint warnings
1f8022f
@botsman botsman mentioned this issue Jan 29, 2019
Merged
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix test_get_labels_from_docker_image_exception_on_missed
ab1af88
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
f4df455
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
0fd064f
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
092b5b3
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
56c832f
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
cf84df2
botsman pushed a commit that referenced this issue Jan 29, 2019
[#686] fix grafana unused args
dbb0813
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
ee6368d
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
5c93f4f
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
f4f0fa0
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
bc71fa0
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
4f3010e
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
e50eeae
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] fix/disable high priority warnings
ceaf197
botsman pushed a commit that referenced this issue Jan 30, 2019
[#686] add check jwt max ttl
1d66279
botsman pushed a commit that referenced this issue Jan 31, 2019
[#686] add check jwt max ttl
ae87bed
botsman pushed a commit that referenced this issue Jan 31, 2019
[#686] add check jwt max ttl
0cb54d4
botsman pushed a commit that referenced this issue Jan 31, 2019
[#686] add check jwt max ttl
7c89e6f
botsman pushed a commit that referenced this issue Jan 31, 2019
[#686] move some of warnings to .pylintrc
a6cf233
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] move .pylintrc to root directory
fa48b5d
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] fix high and normal priority pylint warnings
8b58781
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] fix test_get_labels_from_docker_image_exception_on_missed
fd69c63
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] fix grafana unused args
d900765
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] fix/disable high priority warnings
fb590db
botsman pushed a commit that referenced this issue Feb 4, 2019
[#686] move some of warnings to .pylintrc
a324abf
botsman pushed a commit that referenced this issue Feb 5, 2019
[#686] remove unnecessary disabling warnings
ba13781
botsman pushed a commit that referenced this issue Feb 5, 2019
[#686] remove/disable unused variables
5792c5f
botsman pushed a commit that referenced this issue Feb 5, 2019
[#686] disable too general exceptions checking
9c7d728
botsman pushed a commit that referenced this issue Feb 5, 2019
[#686] fix airflow warnings
42a7481
botsman pushed a commit that referenced this issue Feb 13, 2019
[#686] disable has no member warning
bd76b60
legion-bot pushed a commit that referenced this issue Feb 13, 2019
@legion-bot
[#686] Fix pylint warnings (#767)
fbe3354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@botsman botsman

Labels
CI/CD/tests
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[#686] Fix pylint warnings legion-platform/legion
2 participants
@mcdoker18 @botsman