Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#133] Regression tests are executed two times faster #461

Merged
merged 32 commits into from
Oct 17, 2018
Merged

[#133] Regression tests are executed two times faster #461

merged 32 commits into from
Oct 17, 2018

Conversation

ablatov
Copy link
Member

@ablatov ablatov commented Sep 14, 2018

  • pabot library integration for parallel execution https://github.com/mkorpela/pabot.
  • all tests are separated to 4 suites (4 processes).
  • the third test-bare-model added.
  • jenkins_dex_client updated for the cookies catching before all processes start.
  • tests execution time changed from 40-50 minutes to 15-20 minutes.

@ablatov ablatov added CI/CD/tests improvement [Changed] for changes in existing functionality labels Sep 14, 2018
@ablatov ablatov requested a review from a team as a code owner September 14, 2018 15:15
@ablatov
Copy link
Member Author

ablatov commented Sep 14, 2018

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Sep 15, 2018

ok to test

@kirillmakhonin
Copy link
Member

kirillmakhonin commented Sep 15, 2018 •
edited
Loading

@ablatov please update this branch due to duplicated #438 commits

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov ablatov force-pushed the feat/133-parallel-tests branch 3 times, most recently from 607e6ef to f8ad944 Compare September 15, 2018 11:53
@ablatov
Copy link
Member Author

ablatov commented Sep 15, 2018

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

1 similar comment
@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

1 similar comment
@legion-bot
Copy link
Collaborator

Build status: FAILURE

@dsuslov
Copy link

dsuslov commented Sep 20, 2018

ok to test

1 similar comment
@kirillmakhonin
Copy link
Member

ok to test

@dsuslov
Copy link

dsuslov commented Sep 20, 2018

test this please

@legion-bot
Copy link
Collaborator

Build status: FAILURE

aliaksandr-d
aliaksandr-d previously requested changes Sep 24, 2018
View reviewed changes
k8s/test-bare-model-api/model-3/Dockerfile
@@ -0,0 +1,13 @@
FROM python:3.6-alpine3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add copyrights

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliaksandr-d done.

k8s/test-bare-model-api/model-3/app.py
@@ -0,0 +1,40 @@
from flask import Flask, jsonify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add copyrights

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliaksandr-d done.

k8s/test-bare-model-api/model-3/requirements.txt Outdated
@@ -0,0 +1 @@
Flask==0.10.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flask 0.12.4 is a recommended version

@kirillmakhonin kirillmakhonin force-pushed the feat/133-parallel-tests branch 2 times, most recently from 1dc97a9 to b4e12ea Compare September 27, 2018 12:00
@ablatov ablatov force-pushed the feat/133-parallel-tests branch from 669c897 to 110276a Compare October 1, 2018 10:49
@ablatov ablatov force-pushed the feat/133-parallel-tests branch from b78ce34 to 725a7d5 Compare October 3, 2018 06:00
@ablatov ablatov added the WIP label Oct 10, 2018
@ablatov
Copy link
Member Author

ablatov commented Oct 11, 2018

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Oct 12, 2018

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Oct 12, 2018

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Oct 12, 2018

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Oct 12, 2018

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member Author

ablatov commented Oct 14, 2018

bot, test all

1 similar comment
@ablatov
Copy link
Member Author

ablatov commented Oct 16, 2018

bot, test all

@ablatov ablatov removed the WIP label Oct 16, 2018
@legion-bot
Copy link
Collaborator

Build status: SUCCESS

dsuslov
dsuslov approved these changes Oct 17, 2018
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ablatov ablatov dismissed aliaksandr-d’s stale review October 17, 2018 09:17

all changes were fixed

@ablatov ablatov merged commit b9a825b into develop Oct 17, 2018
@ablatov ablatov deleted the feat/133-parallel-tests branch October 17, 2018 09:27
@ablatov ablatov mentioned this pull request Oct 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillmakhonin kirillmakhonin kirillmakhonin approved these changes

@dsuslov dsuslov dsuslov approved these changes

@aliaksandr-d aliaksandr-d aliaksandr-d left review comments

@akharlamov akharlamov Awaiting requested review from akharlamov

@MaksymBilenko MaksymBilenko Awaiting requested review from MaksymBilenko

Assignees

@ablatov ablatov

Labels
CI/CD/tests improvement [Changed] for changes in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ablatov @legion-bot @kirillmakhonin @dsuslov @aliaksandr-d