Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#479] Remove redundadnt k8s properties changes #498

Merged
merged 2 commits into from
Nov 21, 2018
Merged

[#479] Remove redundadnt k8s properties changes #498

merged 2 commits into from
Nov 21, 2018

Conversation

kirillmakhonin
Copy link
Member

This closes #479
This filters k8s events that script gets on start and on watcher restarts

@kirillmakhonin kirillmakhonin self-assigned this Sep 27, 2018
@kirillmakhonin kirillmakhonin requested review from akharlamov and a team as code owners September 27, 2018 14:30
@kirillmakhonin
Copy link
Member Author

test this please

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

Test this please

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch from ff364ca to 24faf3e Compare September 28, 2018 10:02
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@alexander-semenets
Copy link
Collaborator

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@alexander-semenets
Copy link
Collaborator

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch from 96cf5e7 to 59580d7 Compare October 2, 2018 11:33
@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch 2 times, most recently from cd9f731 to a7c4654 Compare October 18, 2018 11:50
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch from 6754b13 to 8b4cbb2 Compare October 22, 2018 12:13
@kirillmakhonin
Copy link
Member Author

bot, test app

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@kirillmakhonin kirillmakhonin added the bug [Fixed] for any bug fixes. label Nov 12, 2018
dsuslov
dsuslov requested changes Nov 19, 2018
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

deploy/helms/legion/templates/metrics/grafana.yaml Outdated Show resolved Hide resolved
legion/legion/k8s/properties.py Outdated Show resolved Hide resolved
legion/legion/k8s/properties.py Show resolved Hide resolved
legion/legion/k8s/properties.py Outdated Show resolved Hide resolved
@dsuslov dsuslov added the WIP label Nov 19, 2018
@kirillmakhonin
Copy link
Member Author

@dsuslov please re-review
Tests will be started when develop branch became working

@kirillmakhonin
Copy link
Member Author

bot, test app

dsuslov
dsuslov approved these changes Nov 19, 2018
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch from b527524 to 9c3c9f5 Compare November 21, 2018 09:36
@kirillmakhonin kirillmakhonin force-pushed the feat/479-redundadnt-config-map-updates branch from 9c3c9f5 to 9d770c6 Compare November 21, 2018 09:39
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@dsuslov dsuslov merged commit 74fc5a1 into develop Nov 21, 2018
@kirillmakhonin kirillmakhonin deleted the feat/479-redundadnt-config-map-updates branch November 21, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuslov dsuslov dsuslov approved these changes

@akharlamov akharlamov Awaiting requested review from akharlamov

Assignees

@kirillmakhonin kirillmakhonin

Labels
bug [Fixed] for any bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant ConfigMap update events in callback mechanism
4 participants
@kirillmakhonin @legion-bot @alexander-semenets @dsuslov