Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#543] Add EDI unit tests #545

Merged
merged 26 commits into from
Nov 20, 2018
Merged

[#543] Add EDI unit tests #545

merged 26 commits into from
Nov 20, 2018

Conversation

kirillmakhonin
Copy link
Member

@kirillmakhonin kirillmakhonin commented Oct 16, 2018 •
edited by ablatov
Loading

This updates #543
In this PR unit test skeleton for EDI and unit tests for EDI have been added

@kirillmakhonin kirillmakhonin added CI/CD/tests WIP improvement [Changed] for changes in existing functionality labels Oct 16, 2018
@kirillmakhonin kirillmakhonin self-assigned this Oct 16, 2018
@kirillmakhonin kirillmakhonin requested review from akharlamov and a team as code owners October 16, 2018 09:33
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin kirillmakhonin force-pushed the feat/543-edi-unit-tests branch from 388d01f to 02437b4 Compare October 17, 2018 09:54
@kirillmakhonin
Copy link
Member Author

bot, test app

1 similar comment
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

1 similar comment
@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@kirillmakhonin kirillmakhonin force-pushed the feat/543-edi-unit-tests branch from 63b4873 to a15c478 Compare October 19, 2018 16:09
@kirillmakhonin
Copy link
Member Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@ablatov ablatov self-assigned this Nov 6, 2018
@ablatov ablatov force-pushed the feat/543-edi-unit-tests branch from 98d8bf4 to 17b8d9a Compare November 8, 2018 08:52
@ablatov
Copy link
Member

ablatov commented Nov 8, 2018

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member

ablatov commented Nov 8, 2018

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member

ablatov commented Nov 8, 2018

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member

ablatov commented Nov 9, 2018

bot, test app

kirillmakhonin and others added 17 commits November 19, 2018 16:49
@kirillmakhonin
[#543] Fix legionctl EDI client building
9f71cd7
@kirillmakhonin
[#543] Add verbose logging in regr. tests
efaeda9
@kirillmakhonin
[#543] Add condition in tests
5891ec9
@kirillmakhonin
[#543] Add sorting list of models
6b46515
@kirillmakhonin
[#543] Add tests
1166f96
@kirillmakhonin
[#543] Add documentation about tests
93d9b24
@kirillmakhonin
[#543] Add possibility to use different responses in EDI tests
0e89966
[#543] add new EDI unit tests
a04b60c
[#543] add mock files for EDI unit tests
220a585
[#543] fix code stype for EDI unit tests
dcb55e7
[#543] change localhost to IP address in mock files and tests
05892b0
[#543] add mock for building k8s API client
44df846
[#543] fix code style
0ae0045
[#543] fix one line according to code style
ce1eed8
@kirillmakhonin
[#543] Remove redundant features
d2f3615
@kirillmakhonin
[#543] Rename response_code to test_resource_name
d9bdddd
[#543] assert edi unit tests results with dicts
b354b53
@ablatov ablatov force-pushed the feat/543-edi-unit-tests branch from e6ccc67 to b354b53 Compare November 19, 2018 13:50
@ablatov
Copy link
Member

ablatov commented Nov 19, 2018

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@ablatov
Copy link
Member

ablatov commented Nov 19, 2018

bot, test app

@dsuslov dsuslov added the WIP label Nov 19, 2018
@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@ablatov ablatov removed the WIP label Nov 20, 2018
dsuslov
dsuslov approved these changes Nov 20, 2018
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with minor comment

legion/legion/edi/server.py
@@ -298,7 +292,7 @@ def info():

:return: dict -- state of cluster
"""
return app.config['CLUSTER_STATE']
return {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirillmakhonin, why do you return empty set here? If method is deprecated and not used then add TODO and comment that it should be deleted

@dsuslov dsuslov merged commit 259d6e8 into develop Nov 20, 2018
@ablatov ablatov deleted the feat/543-edi-unit-tests branch November 20, 2018 13:24
@kirillmakhonin kirillmakhonin mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuslov dsuslov dsuslov approved these changes

@akharlamov akharlamov Awaiting requested review from akharlamov

Assignees

@kirillmakhonin kirillmakhonin

@ablatov ablatov

Labels
CI/CD/tests critical improvement [Changed] for changes in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirillmakhonin @legion-bot @ablatov @dsuslov