Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#714] Fixed filters and model deploy #724

Merged
merged 1 commit into from
Jan 16, 2019
Merged

[#714] Fixed filters and model deploy #724

merged 1 commit into from
Jan 16, 2019

Conversation

mcdoker18
Copy link
Contributor

@mcdoker18 mcdoker18 commented Jan 10, 2019 •
edited
Loading

  • Checked that model already deployed by model id and version despite of
    image docker name.
  • Moved filters by model id and version on the kubernetes side.
  • Replaced some list kubernetes query by get

This fixes the comment #714 (comment)

@mcdoker18 mcdoker18 added the WIP label Jan 10, 2019
@mcdoker18 mcdoker18 requested a review from a team as a code owner January 10, 2019 17:18
@mcdoker18 mcdoker18 force-pushed the feat/714-filter-deployment-by-label branch from 06bfa21 to ef23443 Compare January 10, 2019 17:22
@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@legion-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@kirillmakhonin
Copy link
Member

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18 mcdoker18 force-pushed the feat/714-filter-deployment-by-label branch 2 times, most recently from b9129cc to b5b495d Compare January 11, 2019 09:48
@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@mcdoker18
Copy link
Contributor Author

bot, test app

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18 mcdoker18 removed the WIP label Jan 12, 2019
@mcdoker18 mcdoker18 self-assigned this Jan 12, 2019
@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

kirillmakhonin
kirillmakhonin requested changes Jan 14, 2019
View reviewed changes
deploy/helms/legion/templates/edi/edi-rbac.yaml Show resolved Hide resolved
legion/legion/k8s/enclave.py Show resolved Hide resolved
legion/legion/k8s/services.py Outdated Show resolved Hide resolved
legion/legion/k8s/services.py Outdated Show resolved Hide resolved
@mcdoker18 mcdoker18 force-pushed the feat/714-filter-deployment-by-label branch from f5478c1 to 30582f9 Compare January 14, 2019 08:23
@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@mcdoker18 mcdoker18 force-pushed the feat/714-filter-deployment-by-label branch 3 times, most recently from e58b9d6 to d740c30 Compare January 16, 2019 14:27
@dsuslov
Copy link

dsuslov commented Jan 16, 2019

bot, test all

dsuslov
dsuslov requested changes Jan 16, 2019
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

legion/legion/k8s/enclave.py Show resolved Hide resolved
dsuslov
dsuslov approved these changes Jan 16, 2019
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 taking into account #736

@mcdoker18
[#714] Fixed filters and model deploy
ae11290 
* Check that model already deployed by model id and version despite of
image docker name.
* Move filters by model id and version on the kubernetes side.
@mcdoker18 mcdoker18 force-pushed the feat/714-filter-deployment-by-label branch from d740c30 to ae11290 Compare January 16, 2019 15:35
@legion-bot
Copy link
Collaborator

Build status: FAILURE

@mcdoker18
Copy link
Contributor Author

bot, test all

1 similar comment
@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@dsuslov dsuslov merged commit ad49b48 into develop Jan 16, 2019
@dsuslov dsuslov deleted the feat/714-filter-deployment-by-label branch January 16, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botsman botsman botsman approved these changes

@kirillmakhonin kirillmakhonin kirillmakhonin approved these changes

@dsuslov dsuslov dsuslov approved these changes

Assignees

@mcdoker18 mcdoker18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcdoker18 @legion-bot @kirillmakhonin @dsuslov @botsman