Fix contrib build with gcc 14 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
codepage.c: In function ‘handle_codepage’:
codepage.c:284:9: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
284 | fread(fonts, CPInfoHeader.size, 1, in);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Originally reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075109
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
Add includes as suggested to fix missing implicit declarations and a
bunch of build failures that appeared with gcc 14:
```
cc -O2 -g -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro splitfont.c -o splitfont
splitfont.c: In function ‘dosplit’:
splitfont.c:19:17: error: implicit declaration of function ‘exit’ [-Wimplicit-function-declaration]
19 | exit(1);
| ^~~~
splitfont.c:8:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
7 | #include <sys/stat.h>
+++ |+#include <stdlib.h>
8 |
splitfont.c:19:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
19 | exit(1);
| ^~~~
splitfont.c:19:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:21:13: error: implicit declaration of function ‘strlen’ [-Wimplicit-function-declaration]
21 | if (strlen(fontfile) >= sizeof(filename) - 4) {
| ^~~~~~
splitfont.c:8:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
7 | #include <sys/stat.h>
+++ |+#include <string.h>
8 |
splitfont.c:21:13: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
21 | if (strlen(fontfile) >= sizeof(filename) - 4) {
| ^~~~~~
splitfont.c:21:13: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
splitfont.c:23:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
23 | exit(1);
| ^~~~
splitfont.c:23:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c: In function ‘main’:
splitfont.c:51:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
51 | exit(1);
| ^~~~
splitfont.c:51:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:56:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
56 | exit(1);
| ^~~~
splitfont.c:56:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:60:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
60 | exit(1);
| ^~~~
splitfont.c:60:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:64:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
64 | exit(1);
| ^~~~
splitfont.c:64:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:69:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
69 | exit(1);
| ^~~~
splitfont.c:69:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:74:17: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
74 | exit(1);
| ^~~~
splitfont.c:74:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
splitfont.c:79:29: error: implicit declaration of function ‘strtoul’ [-Wimplicit-function-declaration]
79 | to = from = strtoul(p, &q, 0);
| ^~~~~~~
splitfont.c:86:25: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
86 | exit(1);
| ^~~~
splitfont.c:86:25: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
```
Originally reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075109
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
andhe
force-pushed
the
fix-contrib-gcc14
branch
from
56323e6 to
d8ba05d
Compare
|
Applied. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included commits fixes build problems with gcc 14 as reported in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075109
BEWARE: These changes has only been compile-tested, not tested on any actual input file!