-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore global error variables (implements #2) #3
Ignore global error variables (implements #2) #3
Conversation
1ca2dcc
to
ff9c8da
Compare
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 54.68% 59.15% +4.46%
==========================================
Files 2 2
Lines 64 71 +7
==========================================
+ Hits 35 42 +7
Misses 27 27
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonklingele Thanks for submitting this so promptly! Thoughts below, let me know what you think.
ff9c8da
to
8710620
Compare
Updated to also catch customly-typed error variables, "fake errors" will no longer be caught. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so exciting.
Error variables are variables starting with 'err' or 'Err'. This implements leighmcculloch#2.
8710620
to
4886830
Compare
This should be fine now @leighmcculloch :) |
@leonklingele 👍, is 3f4f961 better? |
lgtm! :) Thanks for the improvements. |
Error variables are variables starting with 'err' or 'Err' which
were made by either errors.New or fmt.Errorf.
There still is leeway for improvement such as checking if the
node implements the error interface. This would allow us to
whitelist custom error variables.
Fixes #2