Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create intention to suppress Mypy errors #81

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

intgr
Copy link
Collaborator

@intgr intgr commented Dec 5, 2021

This was trickier than expected, but seems to work. :)

Kooha-12-05-2021-22-10-38

Contributor checklist

  • I am using the provided codeStyleConfig.xml
  • I have tested my contribution on these versions of PyCharm/IDEA:
  • PyCharm Community 2021.2.3
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit
    using the Fixes #1234 syntax

Description

Type of Changes

Type
✨ New feature

Related Issue

As discussed in #77.

gradle.properties Show resolved Hide resolved
@leinardi
Copy link
Owner

leinardi commented Dec 5, 2021

Oh wow this is impressive! Thanks a lot!

@leinardi leinardi merged commit 9ecfcf6 into leinardi:master Dec 5, 2021
@intgr
Copy link
Collaborator Author

intgr commented Dec 5, 2021

Unfortunately using the intention from the 'Code -> Inspect Code...' tool does not work.

image

@leinardi
Copy link
Owner

leinardi commented Dec 5, 2021

Should I proceed with a new release?

@intgr
Copy link
Collaborator Author

intgr commented Dec 5, 2021

Unfortunately using the intention from the 'Code -> Inspect Code...' tool does not work.

I think that's because IntelliJ again confusingly has two different APIs for doing the same thing -- LocalQuickFix vs IntentionAction (latter used here).

Anyway I don't feel like investigating that right now. The current implementation works well enough for me. :)

Should I proceed with a new release?

Sure. I don't think the above should be a release blocker.

@leinardi
Copy link
Owner

leinardi commented Dec 5, 2021

Hey, you did a lot for this project, if you want I would be happy give you the Contributor role to the project, let me know if you'll be interested :-)

@intgr
Copy link
Collaborator Author

intgr commented Dec 5, 2021

if you want I would be happy give you the Contributor role to the project

Sure, thanks. I don't feel like I need any special privileges, the current pull request process works well. But I will have a vested interest in this project going forward as well, and can help out with PR code reviews or other tasks.

@leinardi
Copy link
Owner

leinardi commented Dec 5, 2021

Thanks! As you probably have notice, I'm not very active anymore on this project, so I would really appreciate some external contributions!

I just sent you an invitation 👍

And I also just released version 0.12.0 🎉
https://github.com/leinardi/mypy-pycharm/releases/tag/0.12.0

The plugin is under review and should become available in the next 2 days.

@intgr
Copy link
Collaborator Author

intgr commented Dec 7, 2021

As you probably have notice, I'm not very active anymore on this project

Just out of curiosity, do you still use it regularly?

@leinardi
Copy link
Owner

leinardi commented Dec 7, 2021

Regularly? No, I'm an Android developer as my daily job so I work with Kotlin and Java, not Python. I work with Python only when I develop my Linux applications and lately I do not have much time for it.

I wrote these 2 plugins when I started working with Python, because I was used to CheckstyleIDEA for Java. But nowadays I do not use them very often since my linux apps are basically in maintenance mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants