feat(create-meeting): custom url for new meetings #137
Conversation
- allow the user to choose a custom url in the preferences to create a new meeting. The url is opened in the default browser currently
|
We should discuss if we should use a alert or we should use the notification. The problem with notifications is that the user does not allow the notification, so no notification is displayed in this case. Otherwise the notifications looks a little bit nicer. |
We send notifications when a user tries to open an event to which a link was not recognized. I understand the meaning of alerts. But I think our communication should be consistent. And excluding notifications is a user decision that we must respect. If it's a DnD mode, then they will still be in the notification center. |
Yes, I fully understand. If an userbased action is not working, we have to display a hint to the user that something is not working. So I would vote for an dismissable alert. |
|
Do you mean NSAlert or alert style for notification? |
I would say NSAlert. A notification can be dismissed- the user must see that there is something wrong configured when he actively clicks something. Async notifications should stay the macos notifications IMHO. Alternative 1: Check the link on entering in the preferences - this situation for alerting will never happen?! |
|
It makes sense. About the alternatives. The first looks like a crutch and the second is out of the scope of this feature. |
Trying to join the next event is the same for me- the user actively wants to join, but there is no meeting link. If he has not activated the notifications, he will never see the error message. Alternative 3: We could also check if the settings for notifications are switched off and than only show a NSAlert. When the notifications are enabled, we show a notification. WDYT? |
|
Hmm. Alternative 3 looks reasonable. |
- depending on the notification settings of the user, we will display an information via notifications or NSAlerts. - when notifications are enabled, we will send macos notifications - when notifications are disabled, we will send a NSAlert. Testable with an empty custom url to create a new meeting or join the next event when there is no event to join
I have implementation alternative 3. NsAlert will be only used when the user has switched off notifications... I have simplified the url handling for the create new meeting feature and we will allow all kind of urls. The user must enter a valid url with a scheme, e.g. https |
# Conflicts: # MeetingBar/AppDelegate.swift # MeetingBar/Notifications.swift
|
@jgoldhammer, please, resolve the conflicts |
…-new-meetings # Conflicts: # MeetingBar.xcodeproj/project.pbxproj # MeetingBar/PreferencesView.swift
Status
READY
Description
The PR adds the possibility for the user to use a custom url for new meetings.
The link is opened in the standard browser
If the link does not contain a http or https at the beginning, we will add the prefix.
If the link is empty or not valid, an alert is shown to the user.
Steps to Test or Reproduce
Go to preferences, services and choose custom url as option for create meeting.
Add a valid url and try to create the meeting via menubar or shortcut.
The link should be opened in the standard browser.
Delete the url from the preference and try to create the meeting.
An alert should be displayed with a hint.
Enter a not valid url in the preference and try to create a meeting.
An alert should be displayed with a hint.