Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 add CODEOWNERS #415

Merged
merged 4 commits into from
Mar 29, 2023
Merged

👷 add CODEOWNERS #415

merged 4 commits into from
Mar 29, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Mar 26, 2023 •
edited
Loading

Addresses #413

Currently adds these as global CODEOWNERS:

Anyone else who wants to be added or wants to be removed from this preliminary list, please post a comment below.

@techouse techouse self-assigned this Mar 26, 2023
@techouse techouse mentioned this pull request Mar 26, 2023
Closed
JEuler
JEuler reviewed Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@JEuler JEuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we need to contact our father, will you write him?

@JEuler
Copy link
Collaborator

JEuler commented Mar 28, 2023

I have written an email to Hadrien, to add @Guldem as a contributor.

@meysam1717 meysam1717 marked this pull request as ready for review March 28, 2023 10:39
@Guldem
Copy link
Contributor

Guldem commented Mar 28, 2023

I have written an email to Hadrien, to add @Guldem as a contributor.

Thanks!

@techouse
Copy link
Collaborator Author

Right, anyone else wanna be added / removed?

@techouse techouse merged commit 617f3f3 into lejard-h:develop Mar 29, 2023
@techouse techouse deleted the chore/add-codeowners branch March 29, 2023 19:49
@JEuler
Copy link
Collaborator

JEuler commented Apr 3, 2023

Sorry, I have had no luck contacting the @lejard-h about adding the @Guldem to write-buddies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler left review comments

@meysam1717 meysam1717 meysam1717 approved these changes

@pingbird pingbird Awaiting requested review from pingbird

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

Assignees

@techouse techouse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@techouse @JEuler @Guldem @meysam1717