💚 fix publish workflow #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techouse
requested review from
JEuler,
lejard-h,
meysam1717,
pingbird and
stewemetal
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #427 +/- ##
========================================
Coverage 93.63% 93.63%
========================================
Files 8 8
Lines 440 440
========================================
Hits 412 412
Misses 28 28 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JEuler
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR #424 I forgot that the
publish.yamlworkflow does not operate from a pull request but directly on the master branch. That will obviously fail to acquire the previous version. To fix it I changed the checkout process to checkout the master from 1 commit before (HEAD^).